Skip to content

Update README with instructions for platformio #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 3, 2020
Merged

Update README with instructions for platformio #194

merged 2 commits into from
Sep 3, 2020

Conversation

C47D
Copy link
Collaborator

@C47D C47D commented Sep 2, 2020 •
edited
Loading

I don't use platformio to test your instructions @kisvegabor 😅

Closes #168

@C47D C47D requested a review from kisvegabor September 2, 2020 05:41
kisvegabor
kisvegabor reviewed Sep 2, 2020
View reviewed changes
Copy link
Member

@kisvegabor kisvegabor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good. I've just suggested adding some descriptive comments.

@C47D
Copy link
Collaborator Author

C47D commented Sep 2, 2020

I think 9d6974e fix both comments, what do you think?

@C47D C47D marked this pull request as ready for review September 2, 2020 14:10
@C47D C47D merged commit 8dc956c into master Sep 3, 2020
@C47D C47D deleted the add_platformio_instructions branch September 3, 2020 02:41
@kisvegabor
Copy link
Member

Great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kisvegabor kisvegabor kisvegabor left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

.platformio with espidf framework compability
2 participants
@C47D @kisvegabor