Adds Parameters to support 2048 bit keys and Specifying hash_algorithms#31
Merged
Conversation
lvicainne
approved these changes
Oct 12, 2022
lvicainne
left a comment
lvicainne
left a comment
Owner
There was a problem hiding this comment.
Thanks for your contribution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds parameters for supporting multi-line bit keys. For example, a 2048 bit DKIM key is structurally different than the default 1024. Changes add a parameter called "publickeyextended" where you specify the second line. Also adds parameter called "hash_algrothems" which allows you to specify what hash type the DKIM key uses. For example, when creating a key that is using sha256, the DKIM record will contain the hash parameter (ie h=sha256). This will help when migrating from an older hash, ie SHA1 to the more standard SHA256. Both parameters are optional.