Rework module to hiera and epp templates#35
Merged
Conversation
Now that we can remove legacy facts from Puppet (`puppet config set include_legacy_facts false`) we can use this to ensure the module behave as expected. While here, also remove artifacts from the Puppet 3.x era.
cruelsmith
marked this pull request as ready for review
August 23, 2023 08:15
* replace params with hiera layer usage * replace erb templates with epp templates * replace tmpfile.d with RuntimeDirectory in systemd service * add rundir_mode parameter * remove anchor usage * remove inherits usage * mark all classes upside from init as private * add puppet strings * set user as system user to use system user ids per default * first package install and update the user itself ** to ensur proper uid / gid usage
Contributor
|
This PR should be marked as breaking change IMO. At least because all classes aside from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes #32
Fixes #34
Fixes #26