[Feature request] Improve bookmarks panel

[stefonarch]

Is your feature request related to a problem? Please describe.

I never ever use one of the "local bookmarks". Instead of HOME most users will use cd, most terminal user never enter "Music" folder and so on.

Describe the solution you'd like

Hardcoded bookmarks should be removed in favor of only user defined bookmarks, shipping just a list of useful examples.
Also distinction "local" and "synchronized" section would be gone, just "Bookmarks", all of the XDG_* commands would work also if saved remotely,

Context

#789 (comment)

[tsujan]

Hardcoded bookmarks should be removed in favor of only user defined bookmarks

I agree. What's the use of adding cd ... for someone that works with a terminal emulator? If he doesn't know about cd, PWD, HOME, etc., he needs to learn them elsewhere.

[tsujan]

If we remove "Local Bookmarks", I think we should also hide the top branch "Synchronized Bookmarks", so that the user could have his own meaningful tree:

[tsujan]

Apparently, the bookmark functionality isn't used by many; otherwise, there would be an open issue about bookmark filtering, which doesn't work.

[stefonarch]

Apparently, the bookmark functionality isn't used by many; otherwise, there would be an open issue about bookmark filtering, which doesn't work.

True, never used it as they aren't so many here. I specially use them for locations. "Edit bookmartks" is for using featherpad to modify them, downside they get not reloaded on save.

[stefonarch]

IMHO a good and various collection of bookmarks in the default file will show well the potentials.

[tsujan]

I think, before any design change (which will need @yan12125's presence), the filtering should be enabled.

[stefonarch]

Step by step, no hurry.

[tsujan]

Step by step, no hurry.

I agree. Mixed PRs can be a nightmare for reviewers — they are for me.

[yan12125]

Hardcoded bookmarks should be removed in favor of only user defined bookmarks, shipping just a list of useful examples.

That sounds a good idea! Just note that this is a backward-incompatible changes, so upcoming release notes should clearly indicate this and have some tips on how to add XDG folders and/or environment variables back to bookmarks.

downside they get not reloaded on save

Live-reloading is also a nice feature!

IMHO a good and various collection of bookmarks in the default file will show well the potentials.

Good idea! An example with nested groups will be great!

[stefonarch]

I think i would be also better not to show or show the command only in a tooltip - usually the user will know the command a bookmarks execute. It's often half visible and takes to much space all open.

[tsujan]

I think i would be also better not to show or show the command only in a tooltip

I have a ready patch that removes the redundant "Bookmarks" branch as well as hard-coded bookmarks. But I first should make the style changes @yan12125 wanted and merge the previous PR. We could discuss further details later.

[stefonarch]

Still on the wishlist:

• retain state for collapsed, detached etc.
• add bookmarks file: load only .xml files, open ~/.config/qterminal.org/ directory

[tsujan]

retain state for collapsed, detached etc.

I also liked to remember attachment/detachment. Unfortunately, there was a problem: Remembering attachment/detachment isn't enough in practice because we don't want a detached dock in front of the terminal window (it's useless). But positioning of the detached dock beside the terminal window can't be done reliably on startup (to say nothing of Wayland, where it's impossible). The reason is somehow complicated....