Make View maintain ViewData references, bug fixes #8
Conversation
| batch_value = self._batch_map.get(key) | ||
| if batch_value: | ||
| # Update the stored checkpointed value if exists. The call to merge | ||
| # here combines only identical records (same key). | ||
| batch_value.merge(aggregator) |
There was a problem hiding this comment.
I think this case was for the race condition when multiple process occurs at the same time. I don't think you can just call take_checkpoint() because the timestamps would not be correct.
There was a problem hiding this comment.
From what I understand the reason this existed is because if you have multiple boundinstruments which both own ViewDatas with the same key, we need to merge the ViewDatas. However now since there is guaranteed to be only 1 viewdata per key we don't need to merge them anymore
There was a problem hiding this comment.
I think this logic existed even before views existed, so it must have been for something else.
There was a problem hiding this comment.
not sure then. if I add an assert statement assert batch_value == aggregator, all tests will pass, which makes me think that atleast at our testing amount this has no other effect (edit: let me actually verify this.. some tests are failing for other reasons).
opentelemetry-sdk/src/opentelemetry/sdk/metrics/export/batcher.py
Outdated
Show resolved
Hide resolved
cnnradams
changed the title
No description provided.