feat: expose reserved fields in mach-o sections #515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m4b
reviewed
Feb 9, 2026
Owner
m4b
left a comment
m4b
left a comment
There was a problem hiding this comment.
Need to understand why you want this, and probably remove the Clone annotations, I don't see why that's relevant for this
| } | ||
|
|
||
| /// An export trie efficiently encodes all of the symbols exported by this binary for dynamic linking | ||
| #[derive(Clone)] |
Owner
There was a problem hiding this comment.
making this Copy, Clone makes more sense to me; i'm curious why you needed to clone this though?
| /// An interpreter for mach BIND opcodes. | ||
| /// Runs on prebound (non lazy) symbols (usually dylib extern consts and extern variables), | ||
| /// and lazy symbols (usually dylib functions) | ||
| #[derive(Clone)] |
| } | ||
|
|
||
| /// A cross-platform, zero-copy, endian-aware, 32/64 bit Mach-o binary parser | ||
| #[derive(Clone)] |
Owner
There was a problem hiding this comment.
why is this clone? We've avoided these for compile time reasons at this point, and it's never been required in the past, why do you need this? Also adding all these clone annotations has ostensibly nothing to do with your PR title btw
Comment on lines
+65
to
+68
| /// reserved (for offset or index) | ||
| pub reserved1: u32, | ||
| /// reserved (for count or sizeof) | ||
| pub reserved2: u32, |
Owner
There was a problem hiding this comment.
why exactly do you want to see these fields btw? did some real world usecase require it, or? can you elaborate a bit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposes Mach-O
Section32andSection64reserved1andreserved2fields to theSectionstruct