Skip to content

WebAudio: Fix deprecated macros with emscripten 5.0.1+#1097

Closed
FloRecisio wants to merge 1 commit intomackron:devfrom
FloRecisio:emscripten-pragma
Closed

WebAudio: Fix deprecated macros with emscripten 5.0.1+#1097
FloRecisio wants to merge 1 commit intomackron:devfrom
FloRecisio:emscripten-pragma

Conversation

@FloRecisio
Copy link

Hello :) This PR fixes the warnings introduced in Emscripten 5.0.1

miniaudio.h:41459:6: error: macro '__EMSCRIPTEN_major__' has been marked as deprecated: Use __EMSCRIPTEN_MAJOR__ instead [-Werror,-Wdeprecated-pragma]
miniaudio.h:41459:66: error: macro '__EMSCRIPTEN_minor__' has been marked as deprecated: Use __EMSCRIPTEN_MINOR__ instead [-Werror,-Wdeprecated-pragma]
miniaudio.h:41459:124: error: macro '__EMSCRIPTEN_tiny__' has been marked as deprecated: Use __EMSCRIPTEN_TINY__ instead [-Werror,-Wdeprecated-pragma]

@FloRecisio
Copy link
Author

I don't know if this is the best fix because it probably won't compile in earlier versions... maybe I should just ignore the warning on my end.
emscripten-core/emscripten@4cce5e9

@mackron
Copy link
Owner

mackron commented Feb 10, 2026

Thanks for the heads up on this. I don't want to break the build just yet, so I think what I might do is have a MA_EMSCRIPTEN_MAJOR, etc. which wraps around __EMSCRIPTEN_MAJOR/major__ depending on what's available. I can do that manually. Will leave this PR open as a reminder.

An FYI for your own future reference, the split version is created with a tool so no need to duplicate the change there, nor do I accept manual changes to it. No need to update the PR or anything - I'll make this change manually.

mackron added a commit that referenced this pull request Feb 14, 2026
@mackron
Copy link
Owner

mackron commented Feb 14, 2026

This should be addressed in the dev branch. If you were needing this in the split version you can just keep your local changes for the time being, or you can wait until I do the next release.

@mackron mackron closed this Feb 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants