Repository navigation
Conversation
model compiled axum for GenericResponse::send and the validate_api_version middleware, so all ~150 crates that reach model compiled axum through it. Only document_storage_service, agent_harness_service, notification_service and macro_middleware use those two items; they now enable the new axum feature. MACRO-4972
|
Note Some coding-guideline sources were skipped or only partly applied; the reason is listed next to each one. On a public repository, this repository's guideline files are counted without their names. Skipped guideline sources
No actionable comments were generated in the recent review. Summary
Merge Risk:
|
|
Folded into the single reorg PR #10111 (one PR for the whole reorganization). Its commits are there; closing this one. |
Why
Part of the repository reorganization (plan item N2).
modelis the sharedDTO crate that about 150 workspace crates reach, and it compiled
axumfortwo items:
GenericResponse::sendand thevalidate_api_versionmiddleware.Only four crates use them.
MACRO-4972
How it works
modelgets anaxumfeature (off by default) that gatesGenericResponse::send,validate_api_versionand its private helpers.document_storage_service,agent_harness_service,notification_serviceand
macro_middleware, the only callers, enablemodel/axum.models_paginationalready gated axum behind a feature, so it isunchanged.
No crate's dependency closure loses axum yet: I counted with
cargo treeover the 147 crates that reach
model, before and after. Two other pathsstill pull axum in.
workspace-hackadds it throughaxum-extra, andmodel → agent → ai_toolsetadds it directly. Once those edges are cut(N1
chat_message, D7 workspace-hack trim), crates that need onlymodel's DTOs stop compiling axum. Until then this change only makesmodel's own manifest honest.