Skip to content

refactor(search): move SoupProperty into soup_property - #10057

Closed
404Wolf wants to merge 1 commit into
mainfrom
wolf/reorg-soup-property-crate
Closed

404Wolf wants to merge 1 commit into
mainfrom
wolf/reorg-soup-property-crate

Conversation

@404Wolf

@404Wolf 404Wolf commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

Why

Part of the repository reorganization (plan item N14). models_search
depended on models_soup only for SoupProperty, and models_soup's
closure was about 99 workspace crates.

MACRO-4976

How it works

  • SoupProperty and its From<EntityPropertyWithDefinition> move,
    unchanged, into crates/types/soup_property. Its utoipa derive sits behind
    a schema feature.
  • models_soup re-exports it as models_soup::SoupProperty and
    models_soup::properties::SoupProperty, and enables soup_property/schema
    from its own schema feature.
  • models_search depends on soup_property instead of models_soup.
Crate Workspace closure before After
models_search 104 18

This change is independent of the models_soup conversion move
(#10051), which separately shrinks
models_soup itself.

models_search depended on models_soup only for SoupProperty. Move it
into crates/types/soup_property, re-exported as models_soup::SoupProperty,
and point models_search at the new crate. models_search's closure drops
from 104 to 18 workspace crates.

MACRO-4976
@macro-application

Copy link
Copy Markdown

@404Wolf 404Wolf added the run-ci Run CI on the PR's head commit; removed when the run starts label Nov 7, 2026
@github-actions github-actions Bot removed the run-ci Run CI on the PR's head commit; removed when the run starts label Nov 7, 2026
@404Wolf 404Wolf added the run-ci Run CI on the PR's head commit; removed when the run starts label Nov 7, 2026
@coderabbitai

coderabbitai Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

Note

Some coding-guideline sources were skipped or only partly applied; the reason is listed next to each one. On a public repository, this repository's guideline files are counted without their names.

Skipped guideline sources

226 AGENTS.md files in this repository — not scanned for links to other guideline files; the limit of 50 AGENTS.md files per review was reached
168 guideline files in this repository — not read for this review; the limit of 100 guideline files per review was reached

No actionable comments were generated in the recent review.

Summary

Summary by CodeRabbit

  • Refactor
    • Internal data handling was reorganized. No changes to user-visible features or behavior are indicated in this update.

The changes add a workspace crate named soup_property with the public SoupProperty model and a conversion from EntityPropertyWithDefinition. models_soup re-exports the model, and models_search depends on and imports it directly. Workspace dependency closures are updated, including regenerated closures for search-related crates.

Merge Risk: Minimal · up to e52f0

This is a behavior-preserving crate extraction that shrinks the search models' dependency closure. No merge-blocking risk was identified.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title describes the SoupProperty move, follows conventional commits format, and is under 72 characters.
Description check Passed The description matches the SoupProperty move and the dependency changes.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between d7cb768 and e52f078.

Files ignored due to path filters: 1

  • Cargo.lock is excluded by !**/*.lock, !**/Cargo.lock
Files selected for processing: 16

  • .github/workspace-dep-closures.json
  • Cargo.toml
  • crates/models_search/AGENTS.md
  • crates/models_search/Cargo.toml
  • crates/models_search/src/calendar_event.rs
  • crates/models_search/src/call_record.rs
  • crates/models_search/src/chat.rs
  • crates/models_search/src/document.rs
  • crates/models_search/src/email.rs
  • crates/models_search/src/project.rs
  • crates/models_soup/Cargo.toml
  • crates/models_soup/src/properties.rs
  • crates/types/soup_property/AGENTS.md
  • crates/types/soup_property/CLAUDE.md
  • crates/types/soup_property/Cargo.toml
  • crates/types/soup_property/src/lib.rs

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 0 remain after this review.

@github-actions github-actions Bot removed the run-ci Run CI on the PR's head commit; removed when the run starts label Nov 7, 2026
@github-actions

github-actions Bot commented Nov 7, 2026

Copy link
Copy Markdown

@404Wolf

404Wolf commented Nov 7, 2026

Copy link
Copy Markdown
Contributor Author

Folded into the single reorg PR #10111 (one PR for the whole reorganization). Its commits are there; closing this one.

@404Wolf 404Wolf closed this Nov 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant