Repository navigation
Conversation
cargo x deps now keeps a root [workspace.dependencies] entry for every
member at its current path, sorts members one per line, and rewrites
relative path dependencies between members to { workspace = true }.
--check reports manifests that need it. hakari's workspace-hack lines
keep their relative path.
Generated by `cargo x deps`: every member has a root entry, members are
sorted one per line, and the relative path dependencies between members
become { workspace = true }. Feature resolution is unchanged.
cargo x deps now reads .config/layers.toml, places every workspace crate in a layer by directory glob, and prints the normal and build edges that cross layers in a direction the config does not allow. The 26 edges that violate the rules today are baselined as [[allow]] entries with reasons. The report never fails the run.
Also documents how to read and fix the layer report.
The root manifest now lists every workspace crate in [workspace.dependencies]. Hash only the entries of crates in the wasm package's closure, so adding or moving another crate keeps the key.
Took main's manifests where they conflicted and regenerated them with `cargo x deps`.
cargo shear rejects root [workspace.dependencies] entries no member uses, so cargo x deps now drops those and adds an entry once a crate gains its first dependent.
Took main's manifests where they conflicted and regenerated them with `cargo x deps`.
…f/reorg-move-names # Conflicts: # tooling/xtask/crates/xtask_deps/src/main.rs
The crate reorganization moves crates/ into feature groups over a series of PRs. Check in the scripts that do each move, and the map each PR runs, so branches opened before a move can rewrite their own paths with `move_crates.py --rewrite-only` after merging it. MACRO-4984
model-entity, model-error-response and worker-rs-otel were hyphenated packages in hyphenated directories while their lib names were already snake_case; local_e2e_integration_tests did not match its directory. Rename the packages and directories so directory, package and lib name agree, and every dependency key reads like the `use` path. Also drops two layer-baseline entries that main made stale: mcp_client no longer depends on agent, and microsoft_oauth_grant_db_utils is no longer a workspace member. MACRO-4984
This was referenced Nov 7, 2026
Contributor
|
Important Review skippedToo many files! This PR contains 374 files, which is 74 over the limit of 300. To get a review, reduce the PR to 300 files or fewer by splitting it into smaller PRs or changing its base branch. Usage-priced reviews support at most 300 files.
|
This was referenced Nov 7, 2026
This was referenced Nov 7, 2026
Contributor
Author
|
Folded into the single reorg PR #10111 (one PR for the whole reorganization). Its commits are there; closing this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The crate reorganization moves crates/ into feature groups over a
series of PRs. Check in the scripts that do each move, and the map each
PR runs, so branches opened before a move can rewrite their own paths
with
move_crates.py --rewrite-onlyafter merging it.model-entity, model-error-response and worker-rs-otel were hyphenated
packages in hyphenated directories while their lib names were already
snake_case; local_e2e_integration_tests did not match its directory.
Rename the packages and directories so directory, package and lib name
agree, and every dependency key reads like the
usepath.Also drops two layer-baseline entries that main made stale: mcp_client
no longer depends on agent, and microsoft_oauth_grant_db_utils is no
longer a workspace member.
Part of the crate reorganization: crates grouped one level deep by feature,
so the layer rules in
.config/layers.tomlare path globs and relatedcrates sit together. Package names are unchanged unless the title says
otherwise.
Stacked. This branch includes #10022 (root
[workspace.dependencies]) and #10021 (layer check), so CI runs againstmain.Review only
ac9948174e..d48207d207(186 files changed, 1474 insertions(+), 738 deletions(-)).MACRO-5031
MACRO-4984
How it works
tooling/scripts/crate_moves/(first commit) holds the scripts everymove in this series runs, plus one map per move PR, so branches opened
before a move can rewrite their own paths after merging it.
move_crates.py maps/05-names.txtmoved the three hyphenateddirectories and rewrote every path to them;
rename_packages.pyrenamed the four packages in manifests, hakari's lists,
-pflags anddocs. The lib names were already snake_case, so no
useline changes.cargo x depsregenerated.github/workspace-dep-closures.json.Updating an open branch after this lands
Git carries your edits across the renames. A file you added inside a moved
crate shows up as "added in a directory that was renamed": accept git's
suggested location. Then fix paths your branch wrote for the old layout:
For the package renames, also replace
model-entity,model-error-response,worker-rs-otelandlocal_e2e_integration_testswith their snake_casenames in your manifests (
python3 tooling/scripts/crate_moves/rename_packages.py model-entity=model_entity model-error-response=model_error_response worker-rs-otel=worker_rs_otel local_e2e_integration_tests=local_e2e).