Skip to content

feat (ai): auto attach emails - #379

Merged
ehayes2000 merged 2 commits into
mainfrom
auto-attach-emails-2
Dec 1, 2025
Merged

ehayes2000 merged 2 commits into
mainfrom
auto-attach-emails-2

Conversation

@ehayes2000

Copy link
Copy Markdown
Contributor

No description provided.

@ehayes2000
ehayes2000 requested a review from a team as a code owner December 1, 2025 18:26

@gbirman gbirman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two nits: pls address and then merge

import PlusIcon from '@icon/regular/plus.svg?component-solid';
import { DropdownMenu } from '@kobalte/core/dropdown-menu';
import type { EmailEntity } from '@macro-entity';
import { useEmails } from '@macro-entity';

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: group these

// For email splits, find in email list
if (split.content.type === 'email') {
const emailItem =
emailList.find((email) => email.id === split.content.id) || null;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: remove || null since find already returns undefined

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants