Skip to content

fix(email): need to call init always to set link - #392

Merged
synoet merged 4 commits into
mainfrom
synoet/m-5310-email-failing-to-connect
Dec 1, 2025
Merged

synoet merged 4 commits into
mainfrom
synoet/m-5310-email-failing-to-connect

Conversation

@synoet

@synoet synoet commented Dec 1, 2025

Copy link
Copy Markdown
Contributor

This was my mistake. I made an incorrect assumption when refactoring email linking logic. I was assuming that email links got created during sso login in both fusion auth and email service, but it turns out emailClient.init creates the link in email_service.
This pr changes it so on connect & on signup we try to call emailClient.init and properly check the error for a 400 if it already exists to not panic.

Unrelated: seems like error codes aren't being properly propogated from email client rn.

@synoet
synoet requested a review from a team as a code owner December 1, 2025 22:05
@linear

linear Bot commented Dec 1, 2025

Copy link
Copy Markdown

@evanhutnik evanhutnik left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@synoet
synoet merged commit b618a1a into main Dec 1, 2025
@synoet
synoet deleted the synoet/m-5310-email-failing-to-connect branch December 1, 2025 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants