Repository navigation
Conversation
The three per-area vitest configs passed a relative tsconfigPaths root, which vite-tsconfig-paths resolves against the working directory rather than the config file. Tests run from apps/web, so '../../../' pointed above the repository root and the plugin crawled the entire filesystem looking for tsconfigs. On Linux that crawl reaches /proc and fails with EINVAL, so `bun run test` could not start at all; elsewhere it just wasted the walk. Resolve the intended apps/web root from the config file's own URL instead. Co-authored-by: Wolf Mermelstein <wolf@404wolf.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughSummary by CodeRabbit
WalkthroughUpdated three Vitest configurations to derive the Merge Risk: ⚪ Minimal · up to The change keeps Vitest TypeScript configuration discovery within the repository and the test suite passes; no actionable merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Problem
bun run testcannot start on Linux:Three per-area vitest configs pass
tsconfigPaths({ root: '../../../' }).vite-tsconfig-pathsresolvesrootagainst the working directory, not against the config file. Tests run fromapps/web, so'../../../'resolves to/— the plugin then crawls the entire filesystem looking for tsconfigs. On Linux that crawl reaches/proc/<pid>/netand fails withEINVAL, taking every project that extends one of these configs down with it. On macOS there is no/proc, so the walk merely wastes time and the breakage goes unnoticed.The intended root is
apps/web(wheretsconfig.jsonlives), which is also what the top-levelapps/web/vitest.config.tsgets by passing norootat all.Fix
Resolve that root from each config's own URL, so it no longer depends on the working directory:
All three files sit three levels below
apps/web, so the resolved path is unchanged in intent and now correct in fact.Verification
Before, on Linux, the run aborts during project setup. After:
vitest_suite_runs_after_config_fix.log
Split out of #5930, where it was needed to run the suite at all. That PR keeps only the table change.
To show artifacts inline, enable in settings.