Skip to content

add [properties-fe] - properties panel in emails - #612

Merged
danielkweon merged 4 commits into
mainfrom
daniel/m-5178-add-properties-fe-properties-panel-in-emails
Dec 15, 2025
Merged

danielkweon merged 4 commits into
mainfrom
daniel/m-5178-add-properties-fe-properties-panel-in-emails

Conversation

@danielkweon

Copy link
Copy Markdown
Contributor

add [properties-fe] - properties panel in emails

  • Add properties panel to email block with thread subject as document name
  • Fix permissions so users can always edit properties on their own emails
  • Only hide Project metadata when null, show other metadata properties

- Remove unused documentId prop and useBlockId hook
- Pass email subject through props instead of using useBlockDocumentName
- Use EntityType.THREAD constant instead of type assertion
Previously all metadata properties with null values were hidden.
Now only the Project property is hidden when null.
useCanEdit relies on document permission signals that aren't set for
email blocks. Since email threads have no sharing mechanism and users
can only view their own connected account's threads, canEdit is always true.
@danielkweon danielkweon self-assigned this Dec 14, 2025
@danielkweon
danielkweon requested a review from a team as a code owner December 14, 2025 05:01
@linear

linear Bot commented Dec 14, 2025

Copy link
Copy Markdown

@danielkweon
danielkweon merged commit 78c7e01 into main Dec 15, 2025
@danielkweon
danielkweon deleted the daniel/m-5178-add-properties-fe-properties-panel-in-emails branch December 15, 2025 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants