Update app and document icon for Yosemite #1
Conversation
…semite-icon-updated * 'master' of https://github.com/b4winckler/macvim: Fix background color of active tab for Yosemite
…semite-icon-updated * 'master' of https://github.com/macvim-dev/macvim: (311 commits) Snapshot 74 updated for version 7.4.622 Problem: Compiler warning for unused argument. Solution: Add UNUSED. updated for version 7.4.621 Problem: Returning 1 in the wrong function. (Raymond Ko) Solution: Return 1 in the right function (hopefully). updated for version 7.4.620 Problem: Compiler warning for unitinialized variable. (Tony Mechelynck) Solution: Initialize "did_free". (Ben Fritz) updated for version 7.4.619 Problem: luaV_setref() not returning the correct value. Solution: Return one. updated for version 7.4.618 Problem: luaV_setref() is missing a return statement. (Ozaki Kiichi) Solution: Put the return statement back. Update runtime files. updated for version 7.4.617 Problem: Wrong ":argdo" range does not cause an error. Solution: Reset "cmd" to NULL. (Marcin Szamotulski, Ingo Karkat) updated for version 7.4.616 Problem: Cannot insert a tab in front of a block. Solution: Correctly compute aop->start. (Christian Brabandt) updated for version 7.4.615 Problem: Vim hangs when freeing a lot of objects. Solution: Do not go back to the start of the list every time. (Yasuhiro Matsumoto and Ariya Mizutani) updated for version 7.4.614 Problem: There is no test for what patch 7.4.601 fixes. Solution: Add a test. (Christian Brabandt) updated for version 7.4.613 Problem: The NFA engine does not implement the 'redrawtime' time limit. Solution: Implement the time limit. updated for version 7.4.612 Problem: test_eval fails on Mac. Solution: Use the * register instead of the + register. (Jun Takimoto) updated for version 7.4.611 Problem: Syntax error. Solution: Change statement to return. updated for version 7.4.610 Problem: Some function headers may be missing from generated .pro files. Solution: Add PROTO to the #ifdef. updated for version 7.4.609 Problem: For complicated list and dict use the garbage collector can run out of stack space. Solution: Use a stack of dicts and lists to be marked, thus making it iterative instead of recursive. (Ben Fritz) updated for version 7.4.608 Problem: test_eval fails when the clipboard feature is missing. Solution: Skip part of the test. Reduce the text used. updated for version 7.4.607 Problem: Compiler warnings for unused variables. Solution: Move them inside #ifdef. (Kazunobu Kuriyama) updated for version 7.4.606 Problem: May crash when using a small window. Solution: Avoid dividing by zero. (Christian Brabandt) updated for version 7.4.605 Problem: The # register is not writable, it cannot be restored after jumping around. Solution: Make the # register writable. (Marcin Szamotulski) ...
|
Awesome |
|
From the macvim mailing list, from @douglasdrumond:
|
|
Yeah, but this one is not a change per se, just an adjustment of the existing icon(s) to Yosemite aesthetics. The result is still unmistakably the Vim icon set. |
|
The current App Icon is an adaption of the original VIM logo for Apples former Human Interface Guidelines regarding App Icons. |
|
I'm inclined to merge this. It's not a completely new logo, it's Douglas Drumond On Fri, Mar 13, 2015 at 11:47 PM, chdiza [email protected] wrote:
|
|
As a side-note: When this is merged, the wiki-section Notes on document icons should be updated to provide a new download-link to new pre-generated document icons. The entire paragraph might need to be changed, because at least for me the steps to generating the document icons have not worked since Mountain Lion. Over at b4winckler/macvim#44 (comment), @jocelynmallon provided me with pre-generated ones. maybe these could also be linked in the wiki. |
|
👍 |
1 similar comment
|
👍 |
|
👍 Absolutely feel free to include any/all of the pre-made icons on the wiki; @jasonlong and all you guys did the hard work in the first place. |
Update app and document icon for Yosemite
|
Well, I don't like the NEW icon, it's kind of 'weak'. |
|
@pityonline, the time of heavy dark shadows and rugged skeuomorphism in OSX-land is well over since Yosemite. I really like the new icon and think it fits very well into Yosemite overall.
|
|
@cseelus Of course I can customize an icon if I spend some time on it, but I really don't think a USER should waste time on an ugly icon. |
|
Aren't we all "just" users of (mac)vim? Last I checked, there was not customer service, because there are no customers. BTW, I like to new icon. |
|
Although @kzahedi is right in "there's no customer service", I try to do what's better for the community. But, unfortunately, there's no way to please everyone. Since it's _Mac_Vim, the new icons didn't deviate from Vim icon and there was support for it, I decided to upgrade. Let's move forward on this and embrace the new icon. |
Changes pulled from: macvim-dev/macvim#1 Still keeping the classic App icon though
Since it sounds like @b4winckler's original repo is dead, I thought I'd submit this PR here for the updated icon I proposed in b4winckler/macvim#44. It had strong community approval, so I'd ❤️ to see this get merged.
Here is what the icon and document icons look like. Note that this PR now includes all of the filetype document icons that @jocelynmallon built.