Use more descriptive version string in Sparkle 2 #1396
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sparkle 2.4 added support for customizing the displayed version string instead of just showing the "display version" from the manifest (see sparkle-project/Sparkle#2267). Since MacVim has a somewhat non-standard usage of bundle vs display version (bundle is release number, and display version is the upstream Vim version), we really want to show both to the user, in a concise manner. Support this customization so it looks like "r123 (Vim 9.1.2345)" (here, "123" is the bundle version / release number, and "9.1.2345" is the display version / Vim version). Fix macvim-dev#1293
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sparkle 2.4 added support for customizing the displayed version string instead of just showing the "display version" from the manifest (see sparkle-project/Sparkle#2267). Since MacVim has a somewhat non-standard usage of bundle vs display version (bundle is release number, and display version is the upstream Vim version), we really want to show both to the user, in a concise manner. Support this customization so it looks like "r123 (Vim 9.1.2345)" (here, "123" is the bundle version / release number, and "9.1.2345" is the display version / Vim version).
Fix #1293