Add support for RR types 64 and 65 (SVCB and HTTPS) #102
Closed
fishstiqz wants to merge 4 commits intomafintosh:masterfrom
Closed
Add support for RR types 64 and 65 (SVCB and HTTPS) #102fishstiqz wants to merge 4 commits intomafintosh:masterfrom
fishstiqz wants to merge 4 commits intomafintosh:masterfrom
Conversation
* This commit adds support for HTTPS SVCB record, both encoding and decoding.
* Added Service Binding RR support (type 64) This is just using the exact same code as the HTTPS parser as they are formatted in the same manner.
Owner
|
thanks, ci is failing, prop lint i think |
Contributor
|
This command will automatically fix almost all of the lint issues: |
Author
|
Thanks @msimerson, fixing it now |
Author
|
I'm going to resubmit on a different branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for DNS RR types SVCB and HTTPS as defined in RFC 9640.
This code is based on work by @valenting for the mozilla project found here
This should resolve #95