Switch to GitHub Actions#76
Closed
silverwind wants to merge 3 commits into
Closed
Conversation
silverwind
commented
Nov 2, 2021
| push: | ||
| branches: | ||
| - master | ||
| pull_request: |
Collaborator
Author
There was a problem hiding this comment.
e81b402 has restriced CI runs to the master branch only, e.g. it would not run on PRs any more. I'm not sure if that was the intention behind that change, so I reinstated running on PR.
amithm7
reviewed
Nov 3, 2021
| - uses: actions/setup-node@v2 | ||
| with: | ||
| node-version: ${{ matrix.node }} | ||
| - run: npm install |
Contributor
There was a problem hiding this comment.
Maybe add package-lock.json to the repo (it is currently in .gitignore) and use npm ci here instead.
Collaborator
Author
There was a problem hiding this comment.
Not sure I see a benefit there, I use npm install on all my CI setup, specifically not using npm ci because it had odd behaviours/bugs related to native modules last time I checked.
Collaborator
Author
|
Coveralls upload is currently broken, need to investigate. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt to replicate what Travis has done before. The list of tested node versions is probably excessive but it should pass on all of them.