Add Rumble Racing (PS2)#909
Conversation
6f1078f to
75b3a01
Compare
|
A few more things I'd like to add when thinking more about this PR. Since the AI code in the other PR is getting torn up, I also want to be transparent up front about my AI usage before you review it so you don't go crazy wondering First of all, please don't be dissuaded by reviewing this PR based on the 43,000 lines added. Almost 90% of that (37,000 lines) is just JSON data for actor transformations. Ignoring that, the actual amount of relevant LOC is like 5,000 LOC. I am definitely open to storing the JSON data in a different format/approach which would be more compressed and/or not inflate file size/LOC. As far as how AI was used, I used Gemini/Claude to:
There are lots of comments in the Go code which are remnants of earlier code, debugging code commented out, and so on. Since I basically copied the relevant code from my CLI tool and pasted it here, a fair amount of the comments and some code could be considered irrelevant. As we briefly discussed a while ago, you guys said you'd be open to adding Go as a language to noclip. If, after looking at this PR, it seems like it would introduce more annoyances than it's worth, I am fine with re-writing the parsing code in TS / Rust in order to introduce less friction. If you'd rather have me scrap the Go stuff, it won't hurt my feelings. |
|
Thanks for the heads up. Sorry I'm so backed up with reviews.
For data like this, rather than have it be part of the initial code bundle, we could instead store it along with the game data, fetched at runtime. |
Well, this was a marathon of a coding project... This PR adds Rumble Racing to noclip.
A few noteworthy things about this implementation:
Known Visual issues: