add snake case param name #15
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
If we created service interface when have method
public function importQty(object $productQty)
after send bulk request via url rest/async/bulk/V1/my_module/qtyUpdate include body
[ { "product_qty": { "template_id": 11831, "sku": "SKU0000100863", "qty": 13.0 } }, { "product_qty": { "template_id": 11821, "sku": "SKU0000138399", "qty": 13.0 } } ]
then we get 202 status code and response text{ "bulk_uuid": "942a14e7-431f-4a68-8009-2d1671b90eed", "request_items": [ { "id": 0, "data_hash": "64172f83f6b3955c91b4ed80117d6d26b4b3f81be61371b2e4c1769c6c93cf1f", "status": "accepted" }, { "id": 1, "data_hash": "132179362258e95fad607d91cbb96c7300c7620c3665fcff3476146625189557", "status": "accepted" } ], "errors": false }
after we send get request on url rest/V1/bulk/7e989285-c171-4c7b-b9c1-f3d77a7459cc/status and see this error
{ "operations_list": [ { "id": 0, "status": 3, "result_message": "Data item corresponding to \"productQty\" must be specified in the message with topic \"async.utires.odoointegration.api.productimportmanagementinterface.importqty.post\".", "error_code": 0 }, { "id": 1, "status": 3, "result_message": "Data item corresponding to \"productQty\" must be specified in the message with topic", "error_code": 0 } ], "user_type": 1, "bulk_id": "7e989285-c171-4c7b-b9c1-f3d77a7459cc", "start_time": "2021-01-15 14:48:01", "user_id": 96, "operation_count": 2 }
because vendor/magento/framework-message-queue/MessageEncoder.php class doesn't use $snakeCaseParamName variable how vendor/magento/framework/Webapi/ServiceInputProcessor.php
Manual testing scenarios (*)
[ { "product_qty": { "template_id": 11831, "sku": "SKU0000100863", "qty": 13.0 } }, { "product_qty": { "template_id": 11821, "sku": "SKU0000138399", "qty": 13.0 } } ]
we getService execution success
Contribution checklist (*)
Resolved issues: