Skip to content

Phpcs test #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 336 commits into from
Closed

Phpcs test #23

wants to merge 336 commits into from

Conversation

MeetKamal
Copy link
Contributor

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@MeetKamal MeetKamal requested a review from a team as a code owner February 14, 2023 10:59
@sprankhub
Copy link
Contributor

@MeetKamal, thanks for your work here!

I just looked at the changes and I am a bit confused :) I pretty much expected one added file under .github/workflows/. Instead, there are 1549 changed files and many of those changes seem to be unrelated. Actually, https://github.com/MeetKamal/mageos-magento2/blob/phpcs_test/coding-standard/action.yml looks like the only file needed for it? Could you check and clean it up? It might be easier to start with a new clean branch and then just adding the necessary change to it.

@MeetKamal
Copy link
Contributor Author

Hi @sprankhub

Sure will check that and update

@MeetKamal
Copy link
Contributor Author

Hi @sprankhub

As discussed created new branch and deployed required changes, Please review below branch

https://github.com/MeetKamal/mageos-magento2/tree/phpcs_baseline

@sprankhub
Copy link
Contributor

@MeetKamal, could you create a new PR with the new branch and verify that only necessary files are changed?

@sprankhub
Copy link
Contributor

Closing this in favour of #24.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants