Nx unit testing #27
Closed
Nx unit testing #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please leave this with me, I need to debug the unit tests. |
|
closing this as it's replaced by: #31 |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: initial add of unit tests leveraging Nx
fix: unit test checking for wrong format
Adding right to left mark's, which PHPs \NumberFormatter is automatically adding in response.
([U+200F])
Given the involved files haven't been modified in a long time:
app/code/Magento/Directory/Model/Currency.php 9 months
app/code/Magento/Directory/Test/Unit/Model/CurrencyTest.php 6 Months
lib/internal/Magento/Framework/NumberFormatter.php 2 years
I can only guess this is PHP version thing or, has always been here?
magento/magento2@91816f7
Even though the comment is incorrect, this commit must of been the start. (n.b reverting this doesn't fix the issue)