Skip to content

Conversation

@johannes-wolf
Copy link
Contributor

This PR attempts to fix some visual problems with the draft panel:

  • There is a gap between the left and right pane where the background bleeds through
  • The card preview image is rendered at a fixed height, displaying cards smaller then needed
  • Removed some unused foil related code

Before:
Bildschirmfoto vom 2025-12-25 14-59-38

After:
Bildschirmfoto vom 2025-12-25 14-52-51

The .form file is hand-edited and needs to be checked!

@xenohedron
Copy link
Contributor

Good finds, that background bleed was annoying

@johannes-wolf
Copy link
Contributor Author

Yeah, I would like to improve the draft panel further:
Adding a movable splitter would be nice, as the draft cards in the lower view tend to be very small, even on a big monitor, would that be a welcome change?

Also on the left side there is a lot of free space. Showing some draft information like:

  • Number of cards per type
  • Mana curve of drafted cards
  • ...

Could be useful.

@JayDi85
Copy link
Member

JayDi85 commented Dec 30, 2025

It's not easy cause it's shared deck editor component and diff places uses diff panels combination/order/position, so splitter logic is not easy to add or modify (possible bug: wrong panels configuration like minimized/miss bottom panel in draft mode after/before deck editing).

Same for left panel with card hint -- it's same for draft and deck editing... But deck editor has big formats compatibility component that need many space. So it's UX question. Also deck editor and draft has special sort mode, so you can find real stats for diff card params.

@johannes-wolf
Copy link
Contributor Author

Ok. Then this PR is finished and ready for review :)

(The draft UI is currently very “annoying” to use because the hardcoded sizes can make it very hard to read the cards. With this PR the card preview at least gets a little larger, which helps a lot.)

@xenohedron
Copy link
Contributor

Indeed. See existing issue #13609

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants