Skip to content
This repository was archived by the owner on Apr 29, 2019. It is now read-only.

Clean Up Magento/ImportExport/Controller/Adminhtml/History/Download#148

Merged
magento-engcom-team merged 2 commits into
magento-engcom:2.3-developfrom
denispapec:phpstan-historydownload
Nov 22, 2018
Merged

Clean Up Magento/ImportExport/Controller/Adminhtml/History/Download#148
magento-engcom-team merged 2 commits into
magento-engcom:2.3-developfrom
denispapec:phpstan-historydownload

Conversation

@denispapec

Copy link
Copy Markdown
Contributor

Description (*)

  • This PR solves phpstan error by having defined $fileFactory variable.

Fixed Issues (if relevant)

  1. Clean Up Magento/ImportExport/Controller/Adminhtml/History/Download #126: Clean Up Magento/ImportExport/Controller/Adminhtml/History/Download

Manual testing scenarios (*)

  1. Run ./vendor/bin/phpstan analyse -l 0 app/code/Magento/ImportExport/Controller/Adminhtml/History/Download.php
  2. Expected result: No errors

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2

magento-cicd2 commented Oct 28, 2018

Copy link
Copy Markdown
Contributor

CLA assistant check
All committers have signed the CLA.

@dmanners

Copy link
Copy Markdown
Contributor

Hello, thank you for your pull request. I will start to process this PR and get back to you if I need any more information.

dmanners
dmanners previously approved these changes Oct 29, 2018
@magento-engcom-team magento-engcom-team merged commit 518b4d4 into magento-engcom:2.3-develop Nov 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants