Skip to content
This repository was archived by the owner on Apr 29, 2019. It is now read-only.

Removed parameter from constructor inside CustomTest class #149

Conversation

denispapec
Copy link
Contributor

Description (*)

  • this PR solves phpstan error by having parameter inside constructor removed.

Fixed Issues (if relevant)

  1. Call to Magento\ImportExport\Model\Source\Import\Behavior\Custom with constructor arguments #123: Call to Magento\ImportExport\Model\Source\Import\Behavior\Custom with constructor arguments

Manual testing scenarios (*)

  1. ./vendor/bin/phpstan analyse -l 0 app/code/Magento/ImportExport/Test/Unit/Model/Source/Import/Behavior/CustomTest.php
  2. Expected result: No errors

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@denispapec denispapec changed the title Removed parameter from \Magento\ImportExport\Model\Source\Import\Beha… Removed parameter from constructor inside CustomTest class Oct 28, 2018
@dmanners
Copy link
Contributor

Thanks @denispapec for this PR. It looks good. I will start to process this PR now.

@magento-engcom-team
Copy link
Contributor

@denispapec thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants