Skip to content
This repository was archived by the owner on Apr 29, 2019. It is now read-only.

magento/composer does not support PHP 7.2 #2

Closed
buskamuza opened this issue Dec 22, 2017 · 7 comments
Closed

magento/composer does not support PHP 7.2 #2

buskamuza opened this issue Dec 22, 2017 · 7 comments
Assignees
@pmclain
Labels
backward-incompatible blocker requires-ee-changes

Comments

@buskamuza
Copy link
Contributor

buskamuza commented Dec 22, 2017 •
edited
Loading

Update https://github.com/magento/composer, so it supports PHP 7.2

Repo: https://github.com/magento-engcom/magento-composer-php-7.2-support

AC:

Scenarios:

  • Web Setup Wizard: list, update, install an extension
  • Web Setup Wizard: upgrade Magento application to the next version
  • Magento CLI setup:install
  • Magento CLI setup:upgrade
  • Magento CLI module:enable
  • Magento CLI module:disable
  • Cloud setup/deployment
@buskamuza buskamuza changed the title Compatibility of https://github.com/magento/composer with PHP 7.2 https://github.com/magento/composer does not support PHP 7.2 Dec 22, 2017
@buskamuza buskamuza changed the title https://github.com/magento/composer does not support PHP 7.2 magento/composer does not support PHP 7.2 Dec 22, 2017
@buskamuza buskamuza mentioned this issue Dec 22, 2017
Closed
@buskamuza buskamuza mentioned this issue Jan 5, 2018
Closed
@buskamuza
Copy link
Contributor Author

@piotrekkaminski , please review test scenarios and add more scenarios if necessary.

@buskamuza
Copy link
Contributor Author

buskamuza commented Jan 26, 2018 •
edited
Loading

@giabmf11 , https://github.com/magento/composer/blob/master/composer.json#L11 doesn't include PHP 7.2 in the list of supported versions. So it should be added and validated that it's really supported. I updated the description.

@piotrekkaminski
Copy link
Contributor

what about removing an extension? is it supported?
what about manual composer commands
cloud setup/deployment needs to be tested as a scenario

@piotrekkaminski piotrekkaminski removed their assignment Feb 7, 2018
@pmclain pmclain self-assigned this Feb 8, 2018
@buskamuza
Copy link
Contributor Author

@piotrekkaminski, why removing? It's our extension, used in Web Setup Wizard. Magento supports it.
What do you mean under "manual composer commands"? It can't affect Composer itself. But it can affect our CLI commands that use Composer via library.
You're right - cloud should be tested. I'll add it here.

@pmclain pmclain mentioned this issue Feb 10, 2018
Merged
@buskamuza buskamuza mentioned this issue Feb 13, 2018
Merged
@buskamuza
Copy link
Contributor Author

I'm working on merging magento-engcom/magento-composer-php-7.2-support#1
When it's done, Magento repo can be updated with the new version dependency.

Regarding validation of use cases, there were no changes in the code (only in tests), so it should not cause any issues on currently supported versions of PHP, so there is no point in testing now. I propose to go through important scenarios when Magento will be at least installable on PHP 7.2. I'll create a test suite and add scenarios from this ticket there.

@buskamuza
Copy link
Contributor Author

composer/composer should be also updated in the scope of this task (or it will be incompatible with the updated version of magento/composer)

@buskamuza
Copy link
Contributor Author

magento-engcom/magento-composer-php-7.2-support#1 is merged.
Please proceed with updating Magento composer.json.
Please use the branch https://github.com/magento/composer/tree/1.3.0 . Later, when PHP 7.2 work will be done and be ready for merging to mainline, we'll release the tag and will be able to reference it as a normal version.

magento-engcom-team pushed a commit that referenced this issue Mar 2, 2018
Merge pull request #2 from magento/2.1-develop
aa49c8f 
Merge 2.1 develop into northernco
@danielrenaud danielrenaud mentioned this issue Mar 23, 2018
Merged
magento-engcom-team pushed a commit that referenced this issue Apr 22, 2018
@julienanquetil
Merge pull request #2 from magento/2.2-develop
1fffa00 
a
magento-team pushed a commit that referenced this issue May 2, 2018
@hatimeria-artur-jewula @Zefiryn
# This is a combination of 3 commits.
5f3ef1b 
# This is the 1st commit message:
#10765 add confirmation and lock_expires labels to customer grid CSV export

# This is the commit message #2:

#10765 Add tests for added methods

# This is the commit message #3:

10765 code refactoring
magento-engcom-team pushed a commit that referenced this issue May 30, 2018
@yogeshks
Merge pull request #2 from Yogeshks/2.3-develop-PR-port-15364
c0a6b4a 
[Forwardport] Added language translation for comment tag
magento-engcom-team pushed a commit that referenced this issue Jun 7, 2018
@ankurvr
Merge pull request #2 from magento/2.2-develop
56bcffb 
Updated Branch 2.2-develop from Magento 2 upstream
magento-engcom-team pushed a commit that referenced this issue Jun 13, 2018
🔃 [EngCom] Public Pull Requests - 2.1-develop
1d129d7 
Accepted Public Pull Requests:
 - magento/magento2#15829: [Backport] Resolve Error While Trying To Load Quote Item Collection Using Magent� #2 (by @neeta-wagento)
 - magento/magento2#15834: [BackPort] Resolve Knockout non-unique elements id in console error (by @viral-wagento)


Fixed GitHub Issues:
 - magento/magento2#8954: Error While Trying To Load Quote Item Collection Using Magento\Quote\Model\ResourceModel\QuoteItem\Collection::getItems() (reported by @rendyep) has been fixed in magento/magento2#15829 by @neeta-wagento in 2.1-develop branch
   Related commits:
     1. c261156
     2. 950e317

 - magento/magento2#15348: Multiple Payment Methods Enabled is giving error in console "Found 3 Elements with non - unique Id" (reported by @neeta-wagento) has been fixed in magento/magento2#15834 by @viral-wagento in 2.1-develop branch
   Related commits:
     1. b63d2c5
magento-engcom-team added a commit that referenced this issue Jun 19, 2018
@magento-engcom-team
ENGCOM-2003: [Forwardport] Removed unnecessary css. #2 #15798
18a81a8 
 - Merge Pull Request magento/magento2#15798 from chirag-wagento/magento2:2.3-develop-PR-port-15789
 - Merged commits:
   1. cd0a7b4
magento-engcom-team pushed a commit that referenced this issue Jun 19, 2018
ENGCOM-2003: [Forwardport] Removed unnecessary css. #2 #15798
9ef007d
magento-engcom-team pushed a commit that referenced this issue Jun 19, 2018
🔃 [EngCom] Public Pull Requests - 2.3-develop
b8528ae 
Accepted Public Pull Requests:
 - magento/magento2#16135: Fix type hints and add undefined property in Webapi [2.3-develop] (by @mhauri)
 - magento/magento2#16170: 1163: CreateCreditMemoEntityTest rework to support MSI reservation mechanism. (by @nmalevanec)
 - magento/magento2#16153: 1190: CreateOrderBackendPartOneTest rework to support MSI reservation mechanism. (by @nmalevanec)
 - magento/magento2#16061: Change the favicon file to the newer Magento logo (by @DMMundle)
 - magento/magento2#16155: [Forwardport] chore: prefer woff and woff2 (by @DanielRuf)
 - magento/magento2#15777: [Forwardport] Fix negative basket total due to shipping tax residue (by @osrecio)
 - magento/magento2#15861: [Forwardport] ISSUE-14747 Newsletter subscription confirmation message does not dis� (by @rahul-kachhadiya)
 - magento/magento2#16097: [Forwardport] fix: prevent inline-block issue in name form due to space and font-size (by @DanielRuf)
 - magento/magento2#15798: [Forwardport] Removed unnecessary css. #2 (by @chirag-wagento)
 - magento/magento2#16038: [Forwardport] bugfix checkout page cart icon color (by @chirag-wagento)
 - magento/magento2#15759: [Forwardport] 2.3 develop pr port 15566 (by @vgelani)
 - magento/magento2#16137: FIX for apparently random API failures while using array types (by @phoenix128)


Fixed GitHub Issues:
 - magento/magento2#1163: Problem when change less file in magento. (reported by @zivendesign) has been fixed in magento/magento2#16170 by @nmalevanec in 2.3-develop branch
   Related commits:
     1. f53c620

 - magento/magento2#1190: installation error in  0.74.0-beta4 (reported by @sivajik34) has been fixed in magento/magento2#16153 by @nmalevanec in 2.3-develop branch
   Related commits:
     1. 2b8b9d5

 - magento/magento2#14747: Newsletter subscription confirmation message does not display after clicking link in email (reported by @tohann) has been fixed in magento/magento2#15861 by @rahul-kachhadiya in 2.3-develop branch
   Related commits:
     1. 75516bf

 - magento/magento2#16047: inline-block issue in name form (reported by @DanielRuf) has been fixed in magento/magento2#16097 by @DanielRuf in 2.3-develop branch
   Related commits:
     1. 204b4ac

 - magento/magento2#15565: Getting wrong frontend-controller, when using storecodes in urls (reported by @EliasKotlyar) has been fixed in magento/magento2#15759 by @vgelani in 2.3-develop branch
   Related commits:
     1. 61856f5
     2. 4c77dff
magento-engcom-team pushed a commit that referenced this issue Jun 25, 2018
@sanganinamrata
Merge pull request #2 from NamrataChangani/2.3-develop-PR-port-15795
1a76cdb 
[Forwardport] Remove double semicolon from the style sheets.
magento-engcom-team pushed a commit that referenced this issue Jun 29, 2018
@sanganinamrata
Fixed set template syntax in block file #2
86b9895
magento-engcom-team pushed a commit that referenced this issue Jul 18, 2018
@Karlasa
Merge pull request #2 from Karlasa/2.3-develop-PR-port-16190
040e396 
[Forwardport] #16079 translation possibility for moreButtonText
magento-engcom-team pushed a commit that referenced this issue Jul 29, 2018
@sanganinamrata @gelanivishal
Fixed set template syntax in block file #2
98cc752
magento-engcom-team pushed a commit that referenced this issue Aug 14, 2018
@ananth-iyer
Fixed review list ajax if product not exist redirect to 404 page #13102
b81bf67 
#2
magento-engcom-team pushed a commit that referenced this issue Aug 16, 2018
@ananth-iyer @mage2pratik
Fixed review list ajax if product not exist redirect to 404 page #13102
c729a3b 
#2
magento-engcom-team pushed a commit that referenced this issue Aug 18, 2018
@markshust
Merge pull request #2 from magento/2.2-develop
99a616d 
Updating repo
magento-engcom-team pushed a commit that referenced this issue Sep 4, 2018
@jignesh-baldha
Removed unnecessary characters from comments #2
7e19f48
magento-engcom-team pushed a commit that referenced this issue Oct 8, 2018
@jignesh-baldha @lewisvoncken
Removed unnecessary characters from comments #2
a48bb81
magento-engcom-team pushed a commit that referenced this issue Oct 11, 2018
@maximbaibakov
Merge pull request #2 from magento/2.2-develop
b1fcec4 
Sync
magento-engcom-team pushed a commit that referenced this issue Oct 16, 2018
@BezV8
Merge pull request #2 from magento/2.3-develop
25b40f5 
Sync to magento
magento-engcom-team pushed a commit that referenced this issue Oct 25, 2018
Merge pull request #2 from magento/2.2-develop
8c868c3 
2.2 develop
magento-engcom-team pushed a commit that referenced this issue Nov 6, 2018
@swnsma
Merge pull request #2 from magento/2.3-develop
5dc7add 
update
magento-engcom-team pushed a commit that referenced this issue Nov 16, 2018
@ktpl-prakash
Merge pull request #2 from magento/2.3-develop
97d5e9b 
2.3 develop
magento-engcom-team pushed a commit that referenced this issue Nov 22, 2018
@Karlasa
Merge pull request #2 from Karlasa/Karlasa-clean-up-multiwishlist
69107f4 
Karlasa clean up multiwishlist
magento-engcom-team pushed a commit that referenced this issue Nov 22, 2018
@saphaljha
Merge pull request #2 from magento/2.3-develop
8ea303b 
Update repo
magento-engcom-team pushed a commit that referenced this issue Nov 24, 2018
@speedy008
Merge pull request #2 from magento/2.2-develop
301d73d 
2.2 develop-update
magento-engcom-team pushed a commit that referenced this issue Dec 6, 2018
@khodu
Merge pull request #2 from magento/2.3-develop
3ba9281 
merge request
magento-engcom-team pushed a commit that referenced this issue Dec 6, 2018
@Dharmeshvaja91
Merge pull request #2 from magento/2.3-develop
c0d3480 
Update Magento
magento-engcom-team pushed a commit that referenced this issue Dec 9, 2018
@suryakant-krish
Merge pull request #2 from magento/2.3-develop
9143820 
Branch Update
magento-engcom-team pushed a commit that referenced this issue Jan 19, 2019
@niravkrish
Merge pull request #2 from magento/2.3-develop
52130ac 
Latest Magento 2.3
magento-engcom-team pushed a commit that referenced this issue Jan 27, 2019
@DenisSaltanahmedov
Merge pull request #2 from magento/2.3-develop
e595392 
Update 2.3 fork
magento-engcom-team pushed a commit that referenced this issue Feb 10, 2019
@mageprince
Merge pull request #2 from magento/2.3-develop
511b565 
Latest 2.3 develop 24012019
magento-engcom-team pushed a commit that referenced this issue Mar 11, 2019
@lisovyievhenii
Merge pull request #2 from magento/2.2-develop
6bc7575 
2.2 develop
magento-engcom-team pushed a commit that referenced this issue Mar 14, 2019
@ananth-iyer
Fixed mass action design issue #2
314d3a8
magento-engcom-team pushed a commit that referenced this issue Apr 5, 2019
@Thundar
Merge pull request #2 from magento/2.3-develop
bd224a5 
reverse pull request
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pmclain pmclain

Labels
backward-incompatible blocker requires-ee-changes
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@piotrekkaminski @buskamuza @pmclain