Skip to content
This repository was archived by the owner on Apr 29, 2019. It is now read-only.

Eliminate usage of Zend_Mime from Magento 2 Open Source #102

Merged

Conversation

dcabrejas
Copy link

@dcabrejas dcabrejas commented Mar 24, 2018

Description

Add Magento's own Mime class to replace usage of Zend_Mime
Zend_Mime package can now be removed.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

…ource

- Add Magento's own Mime class to replace usage of Zend_Mime
@dcabrejas dcabrejas force-pushed the 67-eliminate-zend-mime-usage branch from 5331672 to 0866244 Compare March 24, 2018 15:37
@bbatsche bbatsche self-assigned this Mar 28, 2018
@bbatsche bbatsche self-requested a review March 28, 2018 16:12
Copy link
Contributor

@bbatsche bbatsche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the call to Zend_Mime_Decode::decodeQuotedPrintable() to use quoted_printable_decode()

Copy link
Contributor

@bbatsche bbatsche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's still one more usage of the Zend_Mime module that should be fixed:
Update the call to Zend_Mime_Decode::decodeQuotedPrintable() to use quoted_printable_decode() IndexTest.php

@buskamuza buskamuza changed the base branch from 2.3-develop to libs-upgrade April 6, 2018 20:21
@buskamuza buskamuza merged commit d733d4d into magento-engcom:libs-upgrade Apr 6, 2018
buskamuza added a commit that referenced this pull request Apr 6, 2018
Eliminate usage of Zend_Mime from Magento 2 Open Source
magento-engcom-team added a commit that referenced this pull request Jul 19, 2018
 - Merge Pull Request magento/graphql-ce#102 from magento/graphql-ce:graphql-fix-the-category-tree-depth-calculation-issue
 - Merged commits:
   1. 9116d82
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants