This repository was archived by the owner on Apr 29, 2019. It is now read-only.
Eliminate usage of Zend_Config from Magento 2 Open Source #71 #103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbatsche
suggested changes
Mar 28, 2018
| @@ -39,7 +39,7 @@ class KeyLength extends \Zend_Validate_StringLength | |||
| * Default encoding is set to utf-8 if none provided | |||
| * New option name added to allow adding key name in validation error messages | |||
| * | |||
| * @param integer|array|\Zend_Config $options | |||
| * @param @inheritDoc | |||
There was a problem hiding this comment.
Should be just @inheritdoc, no @param and all lower case
There was a problem hiding this comment.
@bbatsche That's what happens when you tip over the ballmer peak on a contribution day. Resolved.
…com#71 Remove all references of Zend_Config
knowj
force-pushed
the
bug/72-zend-config
branch
from
b21971b to
97bead2
Compare
bbatsche
approved these changes
Mar 29, 2018
|
Single build failure in Travis is not related to this change and should be merged anyways |
buskamuza
added a commit
that referenced
this pull request
Apr 6, 2018
Eliminate usage of Zend_Config from Magento 2 Open Source #71
magento-engcom-team
added a commit
that referenced
this pull request
Jul 20, 2018
- Merge Pull Request magento/graphql-ce#103 from magento/graphql-ce:25_hide_product_attributes - Merged commits: 1. 7f9d1bc 2. 8f92ef4
magento-engcom-team
pushed a commit
that referenced
this pull request
Jul 20, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove all references of Zend_Config
Removed all instances/references to Zend_Config within the Magento 2 core. The approach with this is to inherit the docblocks in the files where it still exists.
The complete removal of the project dependency on Zend Framework 1 will require the removal of Zend_Validate which is currently in PR:
#82
The changes here aren't reflected in issue 82
Description
Remove import of Zend_Config in oAuth keylength validator and inherit previously copy/pasted Docblock
Import previously copy/pasted docblock from email address validator
Fixed Issues (if relevant)
Manual testing scenarios
No functionality changed import of Zend_Config was purely for usage in Docblock
Contribution checklist