Skip to content
This repository was archived by the owner on Apr 29, 2019. It is now read-only.

Fix #20: Removed each() function usage #28

Closed
wants to merge 1 commit into from

Conversation

YevSent
Copy link
Contributor

@YevSent YevSent commented Jan 16, 2018

Removed each() function usage

Fixed Issues

  1. Usage of deprecated each() function #20: Usage of deprecated each() function

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Copy link
Contributor

@buskamuza buskamuza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add a static test that verifies that each() function is not used in the code? Similar to \Magento\Test\Legacy\UnsecureFunctionsUsageTest

@YevSent
Copy link
Contributor Author

YevSent commented Jan 30, 2018

@buskamuza, yes, sure.

@buskamuza buskamuza added this to the January 2018 milestone Jan 30, 2018
- Removed `each()` function usage
- Update static test to check `each()` usage
@YevSent YevSent closed this Jan 31, 2018
magento-engcom-team added a commit that referenced this pull request Sep 5, 2018
… page in mobile view #17851 #28 #17912

 - Merge Pull Request magento/magento2#17912 from hitesh-wagento/magento2:2.1-develop-PR-port-17877
 - Merged commits:
   1. 9cc8481
magento-engcom-team pushed a commit that referenced this pull request Sep 5, 2018
magento-engcom-team pushed a commit that referenced this pull request Sep 5, 2018
Accepted Public Pull Requests:
 - magento/magento2#17912: [Backport] Resolved : Wishlist icon cut on Shopping cart page in mobile view #17851 #28 (by @hitesh-wagento)


Fixed GitHub Issues:
 - magento/magento2#17851: Wishlist icon cut on Shopping cart page in mobile view (reported by @hitesh-wagento) has been fixed in magento/magento2#17912 by @hitesh-wagento in 2.1-develop branch
   Related commits:
     1. 9cc8481
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants