-
Notifications
You must be signed in to change notification settings - Fork 25
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please run builds and fix issues with count()
- fix static test failure
- fix integrity test failure
- fix test framework unit test
- fix integration tests and static test
@@ -9,6 +9,7 @@ | |||
*/ | |||
namespace Magento\Test\Bootstrap; | |||
|
|||
ob_start(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joanhe Is there a reason for this? I feel like it definitely does not belong here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bbatsche This is to resolve test failure in php 7.2.
session_id(): Cannot change session id when headers already sent in
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe try adding this right above the call that's failing, or somewhere in one of the setUp*()
methods. No code or function calls should be in this file and not inside of the class itself.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the only place works.
# Conflicts: # lib/internal/Magento/Framework/Encryption/Test/Unit/CryptTest.php
- fix static test failure
- fix unit test failure
Description
Add logic and checks to avoid passing
null
tocount()
and make sure that any classes with a publiccount()
method implementCountable
interface.Fixed Issues (if relevant)
Contribution checklist