This repository was archived by the owner on Apr 29, 2019. It is now read-only.
Fix Calls to count()#97
Merged
Merged
Conversation
buskamuza
approved these changes
Mar 20, 2018
Contributor
buskamuza
suggested changes
Mar 20, 2018
buskamuza
left a comment
Contributor
There was a problem hiding this comment.
Please run builds and fix issues with count()
- fix static test failure
- fix integrity test failure
- fix test framework unit test
- fix integration tests and static test
bbatsche
commented
Mar 21, 2018
| */ | ||
| namespace Magento\Test\Bootstrap; | ||
|
|
||
| ob_start(); |
Contributor
Author
There was a problem hiding this comment.
@joanhe Is there a reason for this? I feel like it definitely does not belong here
There was a problem hiding this comment.
@bbatsche This is to resolve test failure in php 7.2.
session_id(): Cannot change session id when headers already sent in
Contributor
Author
There was a problem hiding this comment.
Maybe try adding this right above the call that's failing, or somewhere in one of the setUp*() methods. No code or function calls should be in this file and not inside of the class itself.
# Conflicts: # lib/internal/Magento/Framework/Encryption/Test/Unit/CryptTest.php
- fix static test failure
- fix unit test failure
buskamuza
approved these changes
Mar 26, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add logic and checks to avoid passing
nulltocount()and make sure that any classes with a publiccount()method implementCountableinterface.Fixed Issues (if relevant)
Contribution checklist