This repository was archived by the owner on Apr 29, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 25
Approach to Implementation
Olga Kopylova edited this page Mar 15, 2018
·
2 revisions
- Both PHP 7.1 and 7.2 MUST be supported
- Builds on
2.3-develop
branch are green at any given time
- All fixes MUST follow:
- All builds for the PR MUST be green
- Travis CI - visible for the community
- Internal Magento builds - results provided by the Magento team, if there are any issues
- Main tests are run on PHP 7.1 environment during this stage
- Additional tests are run on temporary branches to prove that a specific fix solves the issue. Such branch may have workarounds to bypass other issues. All workarounds MUST be applied o top of the branch with the fix, so that no fix is missed during the merge
- Make Composer pass environment requirements with PHP 7.2
- PHP requirements updated in
composer.json
to support 7.2 - Update 3rd-party libraries to support PHP 7.2
- PHP requirements updated in
libs-upgrade
branch is used for a combination of issues that can't be fixed one by one. The branch will be merged to mainline (2.3-develop
) when Definition of Done is met (tests are green, QA passed).
PRs merged to libs-upgrade
branch can be found by libs-upgrade search query.
Issues that should be merged to libs-upgrade
branch have a note in the description:
Important: Use libs-upgrade branch as base for this task and as target for the PR.
These include all issues NOT marked with deprecated
or blocker
labels.
These include all issues marked with deprecated
label.
-
Design Document
- Discussion: Encryption with Libsodium
- Info
- ZenHub board
-
Weekly calls(on pause): - Slack: #feature-php-72