Skip to content

Write XMP metadata to a file that does not contain XMP metadata #1554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sivaschenko opened this issue Jul 2, 2020 · 1 comment · Fixed by #1570
Closed

Write XMP metadata to a file that does not contain XMP metadata #1554

sivaschenko opened this issue Jul 2, 2020 · 1 comment · Fixed by #1570
Assignees
@Nazar65
Labels
Backend Complex Priority: P1 Needs to be fixed before any other issues
Milestone
2.1.0

Comments

@sivaschenko
Copy link
Member

sivaschenko commented Jul 2, 2020 •
edited
Loading

Write XMP metadata to a file that does not contain XMP metadata

Technical Design:
https://github.com/magento/adobe-stock-integration/wiki/Technical-Design:-Images-metadata-processing

What needs to be done:

  • Check FileWriter, XmpWriter and Magento\MediaGalleryMetadata\Model\AddXmpMetadata classes
  • Use MediaGalleryMetadata/etc/default.xmp as a template for XMP section
  • Extend Magento\MediaGalleryMetadata\Test\Integration\Model\AddMetadataTest data provider with a test using image without XMP metadata
@m2-assistant
Copy link

m2-assistant bot commented Jul 2, 2020

Hi @sivaschenko. Thank you for your report.
To help us process this issue please make sure that you provided sufficient information.

Please, add a comment to assign the issue: @magento I am working on this

@sivaschenko sivaschenko added Priority: P1 Needs to be fixed before any other issues Complex Backend labels Jul 2, 2020
@sivaschenko sivaschenko added this to the 2.1.0 milestone Jul 2, 2020
@Nazar65 Nazar65 self-assigned this Jul 3, 2020
@Nazar65 Nazar65 mentioned this issue Jul 3, 2020
Merged
@sivaschenko sivaschenko changed the title Write XMP metadata to a file that does not contain XMP metadata Write XMP metadata to a PNG file that does not contain XMP metadata Jul 4, 2020
@sivaschenko sivaschenko changed the title Write XMP metadata to a PNG file that does not contain XMP metadata Write XMP metadata to a file that does not contain XMP metadata Jul 4, 2020
@Nazar65 Nazar65 mentioned this issue Jul 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Nazar65 Nazar65

Labels
Backend Complex Priority: P1 Needs to be fixed before any other issues
Projects
None yet
Milestone
2.1.0
3 participants
@sivaschenko @Nazar65 @lenaorobei