Added Content Status and Store View filters #1602

gabrieldagama · 2020-07-16T10:55:24Z

Description (*)

Added Content Status and Store View filters.

Depends on Added GetAssetIdByContentFieldInterface and implementations magento2#29058

Related Pull Requests

magento/magento2#29058

Fixed Issues (if relevant)

Fixes Introduce Store view filter #1463
Fixes Introduce Enabled filter #1464

Manual testing scenarios (*)

Assign an asset to a content (product, category, page or block)
Go to Content -> Media Gallery and filter by Content Status or Store View
The filter output should be assets that are used on content and the content matches the filter condition.

gabrieldagama · 2020-07-16T10:59:33Z

@magento run all tests

gabrieldagama · 2020-07-16T11:24:11Z

@magento run all tests

gabrieldagama · 2020-07-16T12:36:28Z

@magento run all tests

gabrieldagama · 2020-07-16T13:36:29Z

@magento run all tests

gabrieldagama · 2020-07-17T10:11:30Z

@magento run all tests

chalov-anton · 2020-07-17T13:41:11Z

MediaGalleryUi/Test/Mftf/Test/AdminMediaGalleryDisabledContentFilterTest.xml

+            <useCaseId value="https://github.com/magento/adobe-stock-integration/issues/1464"/>
+            <title value="User filter asset by disabled content"/>
+            <stories value="Story 57: User filters images by the area they used in"/>
+            <testCaseId value="to-be-added"/>


Suggested change

<testCaseId value="to-be-added"/>

<testCaseId value="https://studio.cucumber.io/projects/131313/test-plan/folders/1320712/scenarios/4970565"/>

sivaschenko

Thanks for the PR @gabrieldagama , please see my comments

sivaschenko · 2020-07-17T13:01:52Z

MediaGalleryUi/Model/SearchCriteria/CollectionProcessor/FilterProcessor/ContentField.php

+ */
+class ContentField implements CustomFilterInterface
+{
+    private const TABLE_ALIAS = 'main_table';


A bit of inconsistency: there is a constant for the table name but no constant for id field name. I'd have both on none

sivaschenko · 2020-07-17T13:03:14Z

MediaGalleryUi/Test/Mftf/ActionGroup/AdminMediaGalleryApplySelectFilterActionGroup.xml

+        </annotations>
+        <arguments>
+            <argument name="selectLabel" type="string"/>
+            <argument name="selectOption" type="string"/>


filterLabel and optionLabel argument names would be more descriptive for a developer

MediaGalleryUi/Test/Mftf/Section/AdminEnhancedMediaGalleryFiltersSection.xml

...aGalleryUi/Test/Mftf/ActionGroup/AdminOpenMediaGalleryForExistingPageNoEditorActionGroup.xml

MediaGalleryUi/Test/Mftf/Test/AdminMediaGalleryStoreViewContentFilterTest.xml

modman

gabrieldagama · 2020-07-17T17:49:30Z

@magento run all tests

sivaschenko · 2020-07-21T08:59:59Z

@magento run all tests

gabrieldagama · 2020-07-21T11:24:24Z

@magento run all tests

…ion into introduce-enable-store-view-filters

…ieldagama/adobe-stock-integration into introduce-enable-store-view-filters

gabrieldagama · 2020-07-21T12:56:51Z

@magento run all tests

chalov-anton · 2020-07-21T13:29:40Z

✔️ Great job

The Store view filter handles multiple Sites and Views perfectly

The Content status filter works for Enabled and Disabled Pages, Blocks, Products, Categories

The filters work together with other already existing filters

ghost · 2020-07-21T16:38:59Z

Hi @gabrieldagama, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Gabriel Galvao da Gama added 2 commits July 16, 2020 11:47

Introduced the MediaGalleryContentUi

f9c8493

Fixing conflicts

468ef4a

gabrieldagama added the has dependency label Jul 16, 2020

Moved feature to MediaGalleryUi

dd40f1e

Fixing static tests

6f791d4

chalov-anton reviewed Jul 17, 2020

View reviewed changes

m2-community-project bot assigned chalov-anton Jul 17, 2020

sivaschenko requested changes Jul 17, 2020

View reviewed changes

m2-community-project bot assigned sivaschenko Jul 17, 2020

m2-community-project bot added the Progress: changes requested label Jul 17, 2020

Gabriel Galvao da Gama added 3 commits July 17, 2020 16:48

Addressing code review sugestion

6705d53

Added test case

d9dd48d

Added test case id

727c222

sivaschenko previously approved these changes Jul 21, 2020

View reviewed changes

Merge branch '2.0-develop' into introduce-enable-store-view-filters

d496047

sivaschenko dismissed their stale review via d496047 July 21, 2020 08:59

sivaschenko previously approved these changes Jul 21, 2020

View reviewed changes

m2-community-project bot added Progress: acceptance testing and removed Progress: changes requested labels Jul 21, 2020

Gabriel Galvao da Gama added 2 commits July 21, 2020 13:55

Merge branch '2.0-develop' of github.com:magento/adobe-stock-integrat…

c257842

…ion into introduce-enable-store-view-filters

Merge branch 'introduce-enable-store-view-filters' of github.com:gabr…

1eefe4c

…ieldagama/adobe-stock-integration into introduce-enable-store-view-filters

gabrieldagama dismissed sivaschenko’s stale review via 1eefe4c July 21, 2020 12:56

m2-community-project bot added Progress: ready for delivery and removed Progress: acceptance testing labels Jul 21, 2020

lenaorobei removed the has dependency label Jul 21, 2020

gabrieldagama added Priority: P2 Should be fixed as early as possible and removed Priority: P2 Should be fixed as early as possible labels Jul 21, 2020

m2-community-project bot added the Severity: S2 Affects non-critical data or functionality and forces users to employ a workaround label Jul 21, 2020

gabrieldagama removed Severity: S2 Affects non-critical data or functionality and forces users to employ a workaround Priority: P2 Should be fixed as early as possible labels Jul 21, 2020

m2-community-project bot added the Priority: P2 Should be fixed as early as possible label Jul 21, 2020

gabrieldagama merged commit 535dbb4 into magento:2.0-develop Jul 21, 2020

m2-community-project bot removed the Progress: ready for delivery label Jul 21, 2020

sivaschenko mentioned this pull request Jul 22, 2020

[Sync] Update 2.0-master branch #1629

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added Content Status and Store View filters #1602

Added Content Status and Store View filters #1602

gabrieldagama commented Jul 16, 2020 •

edited

Loading

gabrieldagama commented Jul 16, 2020

gabrieldagama commented Jul 16, 2020

gabrieldagama commented Jul 16, 2020

gabrieldagama commented Jul 16, 2020

gabrieldagama commented Jul 17, 2020

chalov-anton Jul 17, 2020

sivaschenko left a comment

sivaschenko Jul 17, 2020

sivaschenko Jul 17, 2020

gabrieldagama commented Jul 17, 2020

sivaschenko commented Jul 21, 2020

gabrieldagama commented Jul 21, 2020

gabrieldagama commented Jul 21, 2020

chalov-anton commented Jul 21, 2020

ghost commented Jul 21, 2020

	<testCaseId value="to-be-added"/>
	<testCaseId value="https://studio.cucumber.io/projects/131313/test-plan/folders/1320712/scenarios/4970565"/>

Added Content Status and Store View filters #1602

Added Content Status and Store View filters #1602

Conversation

gabrieldagama commented Jul 16, 2020 • edited Loading

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

gabrieldagama commented Jul 16, 2020

gabrieldagama commented Jul 16, 2020

gabrieldagama commented Jul 16, 2020

gabrieldagama commented Jul 16, 2020

gabrieldagama commented Jul 17, 2020

chalov-anton Jul 17, 2020

Choose a reason for hiding this comment

sivaschenko left a comment

Choose a reason for hiding this comment

sivaschenko Jul 17, 2020

Choose a reason for hiding this comment

sivaschenko Jul 17, 2020

Choose a reason for hiding this comment

gabrieldagama commented Jul 17, 2020

sivaschenko commented Jul 21, 2020

gabrieldagama commented Jul 21, 2020

gabrieldagama commented Jul 21, 2020

chalov-anton commented Jul 21, 2020

ghost commented Jul 21, 2020

gabrieldagama commented Jul 16, 2020 •

edited

Loading