Skip to content

Design product compare GraphQL schema #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 21, 2019

Conversation

paliarush
Copy link
Contributor

GraphQL schema for product compare

@paliarush paliarush requested a review from akaplya October 2, 2019 15:21
@paliarush paliarush self-assigned this Oct 2, 2019
@paliarush paliarush mentioned this pull request Oct 2, 2019
@paliarush paliarush mentioned this pull request Oct 9, 2019
productCompareList(compare_list_id: String!): ProductCompareList!
}

input ProductCompareList {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be type?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

}

type Query {
productCompareListId(): String! # ALways new ID for guests. A new or an existing ID for customers
Copy link
Contributor

@akaplya akaplya Oct 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we use ID instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, makes sense.

@buskamuza buskamuza merged commit d52f684 into magento:master Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants