-
Notifications
You must be signed in to change notification settings - Fork 17
Add topic description feature #30
base: 2.3-develop
Are you sure you want to change the base?
Add topic description feature #30
Conversation
|
18aa516
to
ed7ff2f
Compare
Hey, if you will be able to fix tests will be awesome :-) |
That is the plan :) . I will be back on it very soon |
array $entitiesArray, | ||
$groupId = null, | ||
$userId = null, | ||
$bulkDescription = null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really have a strong reason to change method arguments list or we may delay them till the moment when we will have some code that passes this argument?
@phoenix128, @nuzil in #22 we already disabled PHPMD check for coupling between objects in #22 were merged to 2.3.0-release branch. As far as 2.3.0-release will be merged back to 2.3-develop static test should not fail |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Current implementation expects that topic descriptions are provided to descriptions pool in constructor. So this would be declared in di.xml
. However, topics are defined at communication.xml
. It is highly desirable to have all declarations in the same place. So if we don't have strong reasons to not to do that I think we should implement a description pool that fetches descriptions from a config file.
@vkublytskyi |
@phoenix128 we decided to extend webapi.xml with "description" attribute and then generate communication.xml also with "description" attribute and then it can be used on those messages. |
Field name: "successMessage" |
This PR adds the ability to define a topic name both via
\Magento\AsynchronousOperations\Model\MassSchedule::publishMass
parameter and di injection.This will avoid to expose obscure messages from the user's perspective in the Magento backend when an async task is completed.
Currently we get messages like:
While we should have something more user friendly like: