fix double byte characters broken bug.#28
Closed
HirokazuNishi wants to merge 1 commit into
Closed
Conversation
Author
|
@elenleonova , is anybody looking at this pull request? |
|
Thank you @HirokazuNishi , we were able to migrate data with Polish characters thanks to your code. Great work! |
ghost
mentioned this pull request
|
Thank you, @HirokazuNishi. We will merge your pull-request to Data Magento Tool code. |
Collaborator
|
@HirokazuNishi I see you have not signed License Agreement yet. Please do it by clicking on "Details" link |
Collaborator
|
Thank you @HirokazuNishi for for contriburion! The issue was fixed in a different way within this two commits ce958b4 e4abd7c |
This was referenced Jun 16, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I found the reason of double byte characters broken bug.
It's caused by losing mysql connection parameters. By default, PHP's mysql connection uses 'latin1' as its character sets, but Magento uses 'UTF-8'. So double byte characters are always broken without "charset" or "initStatements" option when connecting databases.