Initializing the record transformer before the loop #778
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When migrating data in the EAV Step, the record transformer instance is initialized inside the records loop. This leads to the fact that for each record transformer, new instances of handlers are initialized. Since some handlers make a query to the db and store the result in their properties, it turns out that each new handler instance will execute this query.
A similar issue is present in the Tier Price Step, only the record transformer is initialized inside the pages loop.
Manual testing scenarios
\Migration\Handler\EavAttribute\ApplyTo::checkIfUserDefined()
this handler will transformcatalog_eav_attribute.apply_to
fieldEAV Step
Contribution checklist