Skip to content

Set the null value in the same format #784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 10, 2020

Conversation

DmitryFurs
Copy link
Contributor

@DmitryFurs DmitryFurs commented Feb 3, 2020

Description

\Migration\Handler\SetValue and \Migration\Handler\SetValueAttributeCondition have a different declaration for setting the null value. If we use \Migration\Handler\SetValue, we need to specify NULL in uppercase. And if we use \Migration\Handler\SetValueAttributeCondition, we need to specify null value in lowercase. Also for \Migration\Handler\SetValueAttributeCondition, a comparison of the provided value with null string will be performed for each record in the table.

If we pass values in the wrong format, the value will be inserted as a string.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)

@victor-v-rad
Copy link
Collaborator

Hi @DmitryFurs

Thank you for your contribution to the project. MC-31142 was created to process it.

@victor-v-rad victor-v-rad merged commit 4c9b70d into magento:2.3-develop Feb 10, 2020
@ghost
Copy link

ghost commented Feb 10, 2020

Hi @DmitryFurs, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@DmitryFurs DmitryFurs deleted the DMT-6 branch September 24, 2020 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants