Skip to content

Pass the count mode argument as const instead of int #786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 10, 2020
Merged

Pass the count mode argument as const instead of int #786

merged 1 commit into from
Feb 10, 2020

Conversation

DmitryFurs
Copy link
Contributor

Description

For more convenience we can pass predefined const COUNT_RECURSIVE instead of int value 1

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)

@victor-v-rad
Copy link
Collaborator

Hi @DmitryFurs

Thank you for your contribution to the project. MC-31140 was created to process it.

@victor-v-rad victor-v-rad merged commit d867c24 into magento:2.3-develop Feb 10, 2020
@ghost
Copy link

ghost commented Feb 10, 2020

Hi @DmitryFurs, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@victor-v-rad victor-v-rad mentioned this pull request Apr 27, 2020
Merged
1 task
@DmitryFurs DmitryFurs deleted the DMT-8 branch September 24, 2020 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DmitryFurs @victor-v-rad