Skip to content

Wildcard must represent zero or more characters #790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 2, 2020
Merged

Wildcard must represent zero or more characters #790

merged 2 commits into from
Mar 2, 2020

Conversation

DmitryFurs
Copy link
Contributor

Description

To ignore all the extension tables, we must be able to set only one wildcard rule. For example, to ignore all the tables for the blog by aheadworks, we must specify two rules for ignoring: aw_blog and aw_blog*, since this module has a table aw_blog and has tables aw_blog_cat, aw_blog_cat_store and so on, and the aw_blog* rule is cast to /^aw_blog.+/ regexp. This fix causes the regular expression to look like /^aw_blog.*/ and allows us to ignore such tables by specifying just one wildcard rule

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)

@victor-v-rad
Copy link
Collaborator

Hi @DmitryFurs

Thank you for your contribution to the project. MC-31138 was created to process it.

DmitryFurs
DmitryFurs commented Feb 6, 2020
View reviewed changes
etc/commerce-to-commerce/1.11.0.0/map.xml.dist
@@ -144,9 +144,6 @@
<ignore>
<document>catalog_category_anc_products_index_tmp</document>
</ignore>
<ignore>
<document>catalog_category_flat_cl</document>
</ignore>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Covered by catalog_category_flat* rule

etc/commerce-to-commerce/1.11.0.0/map.xml.dist
@@ -156,9 +153,6 @@
<ignore>
<document>catalog_product_enabled_index</document>
</ignore>
<ignore>
<document>catalog_product_flat_cl</document>
</ignore>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Covered by catalog_product_flat* rule

etc/commerce-to-commerce/1.11.0.0/map.xml.dist
@@ -459,9 +453,6 @@
<ignore>
<document>catalog_category_flat*</document>
</ignore>
<ignore>
<document>catalog_category_flat_store_*</document>
</ignore>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Covered by catalog_category_flat* rule

etc/commerce-to-commerce/1.11.0.0/map.xml.dist
@@ -2022,9 +2013,6 @@
<ignore>
<document>signifyd_case</document>
</ignore>
<ignore>
<document>catalog_product_index_price*</document>
</ignore>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Covered by catalog_product_index* rule

etc/commerce-to-commerce/1.11.0.0/map.xml.dist
@@ -2209,7 +2197,7 @@
<document>sequence_order_*</document>
</ignore>
<ignore>
<document>sequence_shipment*</document>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reduced to a common format with other sequence rules

etc/commerce-to-commerce/1.11.0.0/map.xml.dist
@@ -2355,9 +2343,6 @@
<ignore>
<document>captcha_log</document>
</ignore>
<ignore>
<document>catalog_product_index_group_price</document>
</ignore>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Covered by catalog_product_index* rule

etc/commerce-to-commerce/1.11.0.0/map.xml.dist
</ignore>
<ignore>
<document>catalog_product_index_price*</document>
</ignore>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Covered by catalog_product_index* rule

etc/commerce-to-commerce/1.11.0.0/map.xml.dist
<document>inventory_stock</document>
</ignore>
<ignore>
<document>inventory_stock_*</document>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both covered with new inventory_stock* rule

etc/commerce-to-commerce/1.11.0.0/map.xml.dist
</ignore>
<ignore>
<datatype>catalog_product_index_tier_price.customer_group_id</datatype>
</ignore>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary rules because the table is excluded by catalog_product_index* rule

etc/commerce-to-commerce/1.11.0.0/map.xml.dist
</ignore>
<ignore>
<datatype>catalog_product_index_tier_price.customer_group_id</datatype>
</ignore>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary rules because the table is excluded by catalog_product_index* rule

@victor-v-rad victor-v-rad merged commit 7da169e into magento:2.3-develop Mar 2, 2020
@ghost
Copy link

ghost commented Mar 2, 2020

Hi @DmitryFurs, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@victor-v-rad victor-v-rad mentioned this pull request Apr 27, 2020
Merged
1 task
@DmitryFurs DmitryFurs deleted the DMT-10 branch September 24, 2020 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DmitryFurs @victor-v-rad