Improve informational message #802
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @oroskodias for fixing this issue. The pull request will be processed soon |
|
Ticket to process the PR MC-33122 |
|
Hi @oroskodias, thank you for your contribution! |
|
The PR was merged but \Migration\Step\Eav\Integrity\AttributeGroupNames class will no longer be relevant after #627 is finished |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit improves the informational message for the person who performs migration.
Manual testing scenarios
You have to run migration with multiple attribute sets. If your attribute sets have the same names in M1 then you won't be able to recognize them by name from this error message. I'm adding the ID to make it all clear.
Contribution checklist