Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Incorrect gist in indexing guide #154

Closed
tonegolf71 opened this issue Jan 12, 2015 · 7 comments
Closed

Incorrect gist in indexing guide #154

tonegolf71 opened this issue Jan 12, 2015 · 7 comments

Comments

@tonegolf71
Copy link
Contributor

A gist intended to show an example of Merchandising/etc/indexer.xml is embedded on line 267 in /guides/v1.0/architecture/index-cache/indexing.md.

This is incorrectly displaying a duplicate example of the Merchandising/etc/mview.xml.

@ghost
Copy link

ghost commented Jan 12, 2015

Thanks for pointing this out. I updated the indexer and mview gists; please take a look and let me know if it makes more sense now.

@ghost ghost self-assigned this Jan 12, 2015
@tonegolf71
Copy link
Contributor Author

Hi, sorry to be a pain, I can see you've updated both gists, but you have replaced them with an example of catalog_product_flat. The section they are in is intended as an example for a merchandising module. Previously the mview was correct, but the indexer.xml example was merely a copy of this. What was needed was a correct example of an indexer.xml for a merchandising module.

@ghost
Copy link

ghost commented Jan 12, 2015

My mistake. I went back to some internal source material that clearly didn't match the documentation. I'll try again and get back to you. Thanks for looking at it.

@ghost
Copy link

ghost commented Jan 12, 2015

@tonegolf71 I think I really fixed it this time . Please check. Thanks

@tonegolf71
Copy link
Contributor Author

Great, that's pretty much it. The only other thing I noticed is that it now jumps between UK english "merchandising" and US english "merchandizing" between the examples which might cause some confusion?

@ghost
Copy link

ghost commented Jan 12, 2015

Whew! I just copied from the wrong part of the document.

OK, I can fix that; it'll most likely be updated early next week. I'll get back to you.

@ghost
Copy link

ghost commented Feb 11, 2015

Thank you and we apologize for the delay. Fixed "merchandising".

http://devdocs.magento.com/guides/v1.0/architecture/index-cache/indexing.html

@ghost ghost closed this as completed Feb 11, 2015
magento-team pushed a commit that referenced this issue Feb 9, 2016
magento-cicd2 pushed a commit that referenced this issue Jul 22, 2016
moved Grunt info to a separate topic
magento-devops-reposync-svc pushed a commit that referenced this issue Aug 25, 2021
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant