Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Feedback on page: /guides/v2.3/install-gde/prereq/install-rabbitmq.html #4622

Closed
scm-incomm opened this issue May 28, 2019 · 0 comments
Closed
Labels
2.2.x 2.3.x Magento 2.3 related changes Technical Updates to the code or processes that alter the technical content of the doc

Comments

@scm-incomm
Copy link

scm-incomm commented May 28, 2019

General issue

Description:

The ssl documentation/example configuration is wrong. The parameter
'ssl' => true,
doesn't work. Magento will not communicate with SSL enabled RabbitMQ.

It needs to be corrected to:
'ssl' => 'true'
where "true" must be a string (i.e. true must be in quotes.)

It looks like the code treats the ssl value as a string not as a boolean. The code in question is:
trim($this->getValue(self::SSL)) === 'true';
The code is doing a '===' (i.e. value and type must be equal) which means the "ssl => ..." setting must be a string and it must be equal to 'true'.

The documented setting will not enable Magento to talk to an SSL enabled RabbitMQ instance.

Possible solutions:

Either update the documentation by putting "true" in quotes, or fix the code to treat it as a boolean instead of as a string.

Additional information:

Also noticed the warning / info blocks have incorrect formatting.

@lorikrell lorikrell added groomed 2.2.x 2.3.x Magento 2.3 related changes Technical Updates to the code or processes that alter the technical content of the doc labels Jun 4, 2019
kirtinariya1 added a commit to kirtinariya1/devdocs that referenced this issue Jun 28, 2019
kirtinariya1 added a commit to kirtinariya1/devdocs that referenced this issue Jun 28, 2019
dobooth added a commit that referenced this issue Jun 28, 2019
Fixed #4622 /guides/v2.3/install-gde/prereq/install-rabbitmq.html and v2.2
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
2.2.x 2.3.x Magento 2.3 related changes Technical Updates to the code or processes that alter the technical content of the doc
Projects
None yet
Development

No branches or pull requests

2 participants