Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Clarify PHTML template component key #8106

Closed
Eddcapone opened this issue Oct 22, 2020 · 4 comments
Closed

Clarify PHTML template component key #8106

Eddcapone opened this issue Oct 22, 2020 · 4 comments
Assignees
@DenisSaltanahmedov
Labels
Progress: done

Comments

@Eddcapone
Copy link

Eddcapone commented Oct 22, 2020 •
edited by dobooth
Loading

General issue

Description:

https://devdocs.magento.com/guides/v2.4/javascript-dev-guide/javascript/js_init.html

In chapter Insert a JS component in a PHTML template -> Declarative notation -> Declarative notation using the data-mage-init attribute It says:

If an object is returned, the initializer tries to find the <component_name> key

But there is no information about where it even tries to lookup the key. How can I create the key so it can be found? Basic informations are missing and the topic remains complelty unclear.
@m2-assistant
Copy link

m2-assistant bot commented Oct 22, 2020

Hi @Eddcapone. Thank you for your report.
To help us process this issue please make sure that you provided sufficient information.

Please, add a comment to assign the issue: @magento I am working on this

@dobooth dobooth changed the title Feedback on page: /guides/v2.4/javascript-dev-guide/javascript/js_init.html Clarify PHTML template component key Oct 22, 2020
@DenisSaltanahmedov
Copy link
Contributor

@magento I am working on this

DenisSaltanahmedov added a commit to DenisSaltanahmedov/devdocs that referenced this issue Feb 2, 2021
@DenisSaltanahmedov
magento#8106 Update js_init.md
cbf7769 
Adding more information about component key in the Declarative notation section.
DenisSaltanahmedov added a commit to DenisSaltanahmedov/devdocs that referenced this issue Feb 2, 2021
@DenisSaltanahmedov
magento#8106 Fixing trailing spaces
13ae2d7
DenisSaltanahmedov added a commit to DenisSaltanahmedov/devdocs that referenced this issue Feb 3, 2021
@DenisSaltanahmedov
magento#8106 implementing review recommendations
9bd6b07
dobooth added a commit that referenced this issue Feb 3, 2021
@dobooth
Merge pull request #8609 from DenisSaltanahmedov/improvement-add-js-i…
f6a7753 
…nit-info

#8106 Clarify JS init component key
@DenisSaltanahmedov
Copy link
Contributor

Hi @dobooth the PR is merged, can you clouse the issue?

@dobooth
Copy link
Contributor

dobooth commented Feb 23, 2021

Happily! Thanks for the effort.

@dobooth dobooth closed this as completed Mar 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@DenisSaltanahmedov DenisSaltanahmedov

Labels
Progress: done
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@DenisSaltanahmedov @Eddcapone @dobooth