This repository was archived by the owner on Nov 19, 2024. It is now read-only.
Proposed partial cleanup to Layout overview-Introduction #1699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I tightened up the first part of the introduction of the Layout overview section to introduce and focus on the key concepts: layout, containers, and blocks. I also updated the container and block images by consolidating them into one numbered image that illustrates the three concepts side by side and details those concepts by reference those numbers below the image. I also removed the MVC information from the beginning as it was a bit out of place and distracted from the explanation of the main topics. Reorganization of the other topics within this overview is also needed, but not made in this commit.
|
Thanks @bdenham! We might start asking all candidates to open PRs as part of the recruiting process. |
|
Yeah, well, you just remember who did it first! ;-) |
YevSent
pushed a commit
to YevSent/devdocs
that referenced
this pull request
Feb 12, 2018
2.3 pre-release
|
@bdenham, can you add these updates to the |
|
Done. Let me know if you need me to do anything else. Next step would be to tackle the rest of the layout section by providing various XML file examples (layout handles included) to help cement the concept with the practical. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tightened up the first part of the introduction of the Layout overview section to introduce and focus on the key concepts: layout, containers, and blocks. I also updated the container and block images by consolidating them into one numbered image that illustrates the three concepts side by side and details those concepts by reference those numbers below the image. I also removed the MVC information from the beginning as it was a bit out of place and distracted from the explanation of the main topics.
Reorganization of the other topics within this overview is also needed, but not made in this commit.