-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Conversation
Seems this changes should be targeted to @pmclain, @buskamuza we need to discuss where to contribute docuemntation regarding changes introduced for PHP 7.2 support. Delivering it directly in |
@vkublytskyi , general rule is to deliver docs together with PRs. So I think it's ok to target 2.3 for now. But some doc PRs may be not merged because corresponding dev PRs are not merged. In this case we should be able to duplicate the doc PRs to a necessary branch later. This specific one should be OK - the dev PR should be merged to 2.3-develop w/o waiting for all other tasks. |
@buskamuza, it sounds like everyone agrees that this is a 2.3 change, however this PR is modifying the 2.2 version of the file. If we're targeting 2.3, we must update the 2.3 version of the file; not the 2.2 version. @dshevtsov, please don't merge this PR until we get confirmation. |
Yes. It should be 2.3. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dshevtsov, please make these changes to the guides/v2.3/config-guide/redis/redis-session.md
file instead.
You'll need to delete the current guides/v2.3/config-guide/redis/redis-session.md
symlink, create a new 2.3 file based on the 2.2 content, and then make these changes.
I created an internal ticket: MAGEDOC-2798 |
@pmclain I replaced a symlink Please update your PR to move your changes to |
@buskamuza is this PR still relevant? |
I pulled the changes, moved them to 2.3, and published in a separate commit. |
magento-engcom/php-7.2-support#39
magento-engcom/php-7.2-support#1