Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Document Redis Sentinel settings #1706

Closed
wants to merge 1 commit into from
Closed

Conversation

pmclain
Copy link
Contributor

@pmclain pmclain commented Feb 14, 2018

@vkublytskyi vkublytskyi removed the 2.2.x label Feb 14, 2018
@dshevtsov dshevtsov added Major Update Significant original updates to existing content In progress labels Feb 14, 2018
@vkublytskyi
Copy link
Contributor

Seems this changes should be targeted to guides/v2.3/config-guide/redis/redis-session.md as provided information will not be correct for M2.2.

@pmclain, @buskamuza we need to discuss where to contribute docuemntation regarding changes introduced for PHP 7.2 support. Delivering it directly in guides/v2.3/ may cause an issue if project will not be finished before 2.3.0 release.

@dshevtsov dshevtsov assigned dshevtsov and unassigned jhill-magento Feb 14, 2018
@buskamuza
Copy link
Contributor

@vkublytskyi , general rule is to deliver docs together with PRs. So I think it's ok to target 2.3 for now. But some doc PRs may be not merged because corresponding dev PRs are not merged. In this case we should be able to duplicate the doc PRs to a necessary branch later.

This specific one should be OK - the dev PR should be merged to 2.3-develop w/o waiting for all other tasks.

@jeff-matthews
Copy link
Contributor

@buskamuza, it sounds like everyone agrees that this is a 2.3 change, however this PR is modifying the 2.2 version of the file. If we're targeting 2.3, we must update the 2.3 version of the file; not the 2.2 version.

@dshevtsov, please don't merge this PR until we get confirmation.

@buskamuza
Copy link
Contributor

Yes. It should be 2.3.

@jeff-matthews jeff-matthews self-requested a review February 14, 2018 15:59
Copy link
Contributor

@jeff-matthews jeff-matthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dshevtsov, please make these changes to the guides/v2.3/config-guide/redis/redis-session.md file instead.

You'll need to delete the current guides/v2.3/config-guide/redis/redis-session.md symlink, create a new 2.3 file based on the 2.2 content, and then make these changes.

@jeff-matthews jeff-matthews added the Internal Dev Differentiates work between community and Magento staff label Feb 14, 2018
@dshevtsov
Copy link
Collaborator

I created an internal ticket: MAGEDOC-2798

@dshevtsov dshevtsov added the Tracking Created an internal Jira ticket to track work label Feb 14, 2018
@dshevtsov
Copy link
Collaborator

dshevtsov commented Feb 19, 2018

@pmclain I replaced a symlink guides/v2.3/config-guide/redis/redis-session.md with a copy of the guides/v2.2/config-guide/redis/redis-session.md file.

Please update your PR to move your changes to guides/v2.3/config-guide/redis/redis-session.md instead of guides/v2.2/... (according to the above conversation).

@dshevtsov dshevtsov added Waiting for Response Waiting for response from internal/external parties and removed In progress labels Feb 20, 2018
@dshevtsov
Copy link
Collaborator

@buskamuza is this PR still relevant?

@dshevtsov
Copy link
Collaborator

I pulled the changes, moved them to 2.3, and published in a separate commit.

@dshevtsov dshevtsov closed this May 1, 2018
@dshevtsov dshevtsov removed Waiting for Response Waiting for response from internal/external parties Major Update Significant original updates to existing content labels May 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Internal Dev Differentiates work between community and Magento staff Tracking Created an internal Jira ticket to track work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants