Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Remove extra space and close <image> tag #1920

Merged
merged 1 commit into from
May 20, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ Configure it using the following example (replace placeholders with your {% glos
<theme xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:Config/etc/theme.xsd">
<title>%Theme title%</title> <!-- your theme's name -->
<parent>%vendor_dir%/%parent_theme_dir%</parent> <!-- the parent theme. Example: Magento/backend -->
</theme>
</theme>
{%endhighlight%}

If you change the theme title or parent theme information in `theme.xml` after a theme was already [registered](#register_theme), you need to open or reload any {% glossarytooltip 18b930cf-09cc-47c9-a5e5-905f86c43f81 %}Magento Admin{% endglossarytooltip %} page for your changes to be saved in the database.
Expand Down
6 changes: 3 additions & 3 deletions guides/v2.0/frontend-dev-guide/themes/theme-inherit.md
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ the Orange theme by OrangeCo inherits from the Magento Blank theme. The inherita
<media>
<preview_image>media/preview.jpg</preview_image>
</media>
</theme>
</theme>
{% endhighlight xml %}

<div class="bs-callout bs-callout-info" id="info">
Expand Down Expand Up @@ -115,15 +115,15 @@ For example, if you must override the `<Magento_Catalog_module_dir>/view/fronten

<u>Example</u>
By default, according to the module template, in the mini {% glossarytooltip c7ecb18d-cefe-452d-83e2-3c4d5e355db9 %}shopping cart{% endglossarytooltip %} products are listed under the Go to {% glossarytooltip 278c3ce0-cd4c-4ffc-a098-695d94d73bde %}Checkout{% endglossarytooltip %} button:
<p><img src="{{ site.baseurl }}/common/images/inherit_mini1.png" alt="In the minishopping cart products are listed under the Go to Checkout button "></p>
<p><img src="{{ site.baseurl }}/common/images/inherit_mini1.png" alt="In the minishopping cart products are listed under the Go to Checkout button"/></p>

The order is defined in the `<Magento_Checkout_module_dir>/view/frontend/templates/cart/minicart.phtml` module template. The Blank theme does not override this template.
OrangeCo decided they want the product list to be displayed before the Go to Checkout button.
To do this, they need to add an overriding template for the corresponding module in the Orange theme folder:
`app/design/frontend/OrangeCo/orange/Magento_Checkout/templates/cart/minicart.phtml`
Note, that the path to the template inside the `templates` directory in the theme corresponds to that in the module.
Having changed the order or elements in the templates, OrangeCo got the minicart look like following:
<p><img src="{{ site.baseurl }}/common/images/inherit_mini2.png" alt="In the minishopping cart products are listed above the Go to Checkout button "></p>
<p><img src="{{ site.baseurl }}/common/images/inherit_mini2.png" alt="In the minishopping cart products are listed above the Go to Checkout button"/></p>
You can find out what exactly code changes are required to perform this and other tasks in the <a href="{{ page.baseurl }}/frontend-dev-guide/templates/template-sample.html">Illustration of customizing templates topic</a>.

## Extend layouts {#theme-inherit-layout}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ Configure it using the following example (replace placeholders with your {% glos
<theme xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:Config/etc/theme.xsd">
<title>%Theme title%</title> <!-- your theme's name -->
<parent>%vendor_dir%/%parent_theme_dir%</parent> <!-- the parent theme. Example: Magento/backend -->
</theme>
</theme>
{%endhighlight%}

If you change the theme title or parent theme information in `theme.xml` after a theme was already [registered](#register_theme), you need to open or reload any {% glossarytooltip 18b930cf-09cc-47c9-a5e5-905f86c43f81 %}Magento Admin{% endglossarytooltip %} page for your changes to be saved in the database.
Expand Down
6 changes: 3 additions & 3 deletions guides/v2.1/frontend-dev-guide/themes/theme-inherit.md
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ the Orange theme by OrangeCo inherits from the Magento Blank theme. The inherita
<media>
<preview_image>media/preview.jpg</preview_image>
</media>
</theme>
</theme>
{% endhighlight xml %}

<div class="bs-callout bs-callout-info" id="info">
Expand Down Expand Up @@ -113,15 +113,15 @@ For example, if you must override the `<Magento_Catalog_module_dir>/view/fronten

<u>Example</u>
By default, according to the module template, in the mini {% glossarytooltip c7ecb18d-cefe-452d-83e2-3c4d5e355db9 %}shopping cart{% endglossarytooltip %} products are listed under the Go to {% glossarytooltip 278c3ce0-cd4c-4ffc-a098-695d94d73bde %}Checkout{% endglossarytooltip %} button:
<p><img src="{{ site.baseurl }}/common/images/inherit_mini1.png" alt="In the minishopping cart products are listed under the Go to Checkout button "></p>
<p><img src="{{ site.baseurl }}/common/images/inherit_mini1.png" alt="In the minishopping cart products are listed under the Go to Checkout button"/></p>

The order is defined in the `<Magento_Checkout_module_dir>/view/frontend/templates/cart/minicart.phtml` module template. The Blank theme does not override this template.
OrangeCo decided they want the product list to be displayed before the Go to Checkout button.
To do this, they need to add an overriding template for the corresponding module in the Orange theme folder:
`app/design/frontend/OrangeCo/orange/Magento_Checkout/templates/cart/minicart.phtml`
Note, that the path to the template inside the `templates` directory in the theme corresponds to that in the module.
Having changed the order or elements in the templates, OrangeCo got the minicart look like following:
<p><img src="{{ site.baseurl }}/common/images/inherit_mini2.png" alt="In the minishopping cart products are listed above the Go to Checkout button "></p>
<p><img src="{{ site.baseurl }}/common/images/inherit_mini2.png" alt="In the minishopping cart products are listed above the Go to Checkout button"/></p>
You can find out what exactly code changes are required to perform this and other tasks in the <a href="{{ page.baseurl }}/frontend-dev-guide/templates/template-sample.html">Illustration of customizing templates topic</a>.

## Extend layouts {#theme-inherit-layout}
Expand Down