This repository was archived by the owner on Nov 19, 2024. It is now read-only.
MAGEDOC-2893: Magento binding syntax #2126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcalcaben
approved these changes
Jun 6, 2018
| |textInput |`<input data-bind="textInput: value"/>` | `<input textInput="value"/>` | | ||
| |value |`<input data-bind="value: value"/>` | `<input ko-value="value"/>` | | ||
| |checked |`<input type="chackbox" data-bind="checked: isChecked"/>` | `<input type="chackbox" ko-checked="isChecked"/>` | | ||
| |checkedValue |`<input type="chackbox" data-bind="checkedValue: $data, checked: isChecked"/>` | `<input type="chackbox" checkedValue="$data" checked="isChecked"/>` | |
There was a problem hiding this comment.
Append the following on the next line of this table to get a better table format:
{:style="table-layout:auto"}
There was a problem hiding this comment.
ah, awesome. will do.
| |foreach |`<!-- ko foreach: elements --><!-- /ko -->` | `<each args="elements">` | | ||
| | |`<div data-bind="foreach: elements"></div>` | `<div each="elements"></div>` | | ||
| |component |`<!-- ko component: 'componentName' --> <!-- /ko -->` | `<component args="'componentName'">` | | ||
| | |`<div data-bind="component: componentName"> </div>` | `<div component="'componentName'"> </div>` | |
There was a problem hiding this comment.
<div data-bind="component: componentName"> </div> missed single quotes -> <div data-bind="component: 'componentName'"> </div>
| |hasFocus |`<input data-bind="hasFocus: onFocus"/>` | `<input ko-focused="onFocus"/>` | | ||
| |textInput |`<input data-bind="textInput: value"/>` | `<input textInput="value"/>` | | ||
| |value |`<input data-bind="value: value"/>` | `<input ko-value="value"/>` | | ||
| |checked |`<input type="chackbox" data-bind="checked: isChecked"/>` | `<input type="chackbox" ko-checked="isChecked"/>` | |
There was a problem hiding this comment.
type="chackbox"->type="checkbox"
| |textInput |`<input data-bind="textInput: value"/>` | `<input textInput="value"/>` | | ||
| |value |`<input data-bind="value: value"/>` | `<input ko-value="value"/>` | | ||
| |checked |`<input type="chackbox" data-bind="checked: isChecked"/>` | `<input type="chackbox" ko-checked="isChecked"/>` | | ||
| |checkedValue |`<input type="chackbox" data-bind="checkedValue: $data, checked: isChecked"/>` | `<input type="chackbox" checkedValue="$data" checked="isChecked"/>` | |
There was a problem hiding this comment.
type="chackbox"->type="checkbox"
|
Thanks @omiroshnichenko. Good catches! |
omiroshnichenko
approved these changes
Jun 7, 2018
dshevtsov
removed
the
Technical
|
@bdenham please add |
|
I added the whatsnew. |
lorikrell
added
New Topic
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a:
Summary
When this pull request is merged, it will create a new topic that shows developers how to use the Magento binding syntax for UI components instead of the more complex Knockout binding equivalents.
Additional information
HTML preview: http://cicd1.corp.magento.com/~mmansoor/devdocs/gh-pages/branches/bd-magedoc-2893-mage-binding/_site/guides/v2.2/ui_comp_guide/concepts/magento-bindings.html
Jira story: https://jira.corp.magento.com/browse/MAGEDOC-2893
whatsnew
Added a topic about the Magento binding syntax.