This repository was archived by the owner on Nov 19, 2024. It is now read-only.
GraphQL request and response correction #3652
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of "relative_url" it should be "canonical_url"
magento-engcom-team
added
Partner: Wagento
|
An admin must run tests on this PR before it can be merged. |
jeff-matthews
added
2.3.x
|
The attribute was renamed from |
|
Yes correct. Basically for 2.3 it makes sense, but from 2.3.1 it will be switched back |
|
The rename of renamed from |
keharper
suggested changes
Feb 5, 2019
keharper
approved these changes
Mar 3, 2019
|
running tests |
|
Hi @hiren-wagento, thank you for your contribution! |
|
I finished this because it was holding up changes to be made in the 2.3.1 integration branch. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of "relative_url" it should be "canonical_url"
This PR is a:
Summary
When this pull request is merged, it will correct the Example usage of urlResolver endpoint
Additional information
List all affected URLs
https://devdocs.magento.com/guides/v2.3/graphql/reference/url-resolver.html