This repository was archived by the owner on Nov 19, 2024. It is now read-only.
Adding GraphQL CMS and Theme Attributes to storeConfig #3803
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keharper
suggested changes
Feb 21, 2019
| `cms_no_route` | String | Identifies a specific CMS page that you want to appear when a 404 “Page Not Found” error occurs | ||
| `front` | String | Indicates the landing page that is associated with the base URL | ||
| `no_route` | String | Contains the URL of the default page that you want to appear when if a 404 “Page not Found” error occurs | ||
| `show_cms_breadcrumbs` | Int | Determines if a breadcrumb trail appears on all CMS pages in the catalog. Options: Yes / No |
There was a problem hiding this comment.
The value can't be Yes/No when the value is an Int
| --- | ||
|
|
||
| The `storeConfig` endpoint returns information about a store's configuration, including its locale, currency codes, and the secure and unsecure URLs. | ||
| The `Store` endpoint defines information about a store's configuration. |
There was a problem hiding this comment.
Add a link to https://devdocs.magento.com/guides/v2.3/graphql/send-request.html with an explanation that the Store header allows you to query a non-default store.
|
|
||
| ### Supported theme attributes | ||
|
|
||
| Use the `theme` attributes to retrieve information about the store's thematic elements; such as, footer and header information, copyright text, and logo information. |
There was a problem hiding this comment.
Mention these attributes are defined in the ThemeGraphQl module.
| `default_description` | String | The description that provides a summary of your site for search engine listings and should not be more than 160 characters in length | ||
| `default_keywords` | String | A series of keywords that describe your store, each separated by a comma | ||
| `default_title` | String | The title that appears at the title bar of each page when viewed in a browser | ||
| `demonotice` | Int | Controls the display of the demo store notice at the top of the page. Options include: Yes / No |
There was a problem hiding this comment.
The value can't be Yes/No when the value is an Int
|
|
||
| Attribute | Data Type | Description | ||
| --- | --- | --- | ||
| `absolute_footer` | String | Contains scripts that must be included in the HTML before the closing <body> tag |
There was a problem hiding this comment.
Suggested change
| `absolute_footer` | String | Contains scripts that must be included in the HTML before the closing <body> tag | |
| `absolute_footer` | String | Contains scripts that must be included in the HTML before the closing `<body>` tag |
There was a problem hiding this comment.
You don't need to escape the less/greater than signs.
| `default_keywords` | String | A series of keywords that describe your store, each separated by a comma | ||
| `default_title` | String | The title that appears at the title bar of each page when viewed in a browser | ||
| `demonotice` | Int | Controls the display of the demo store notice at the top of the page. Options include: Yes / No | ||
| `head_includes` | String | Contains scripts that must be included in the HTML before the closing <head> tag |
There was a problem hiding this comment.
Suggested change
| `head_includes` | String | Contains scripts that must be included in the HTML before the closing <head> tag | |
| `head_includes` | String | Contains scripts that must be included in the HTML before the closing `<head>` tag |
| {:style="table-layout:auto;"} | ||
|
|
||
| ### Supported CMS attributes | ||
|
|
||
| Use the `cms` attributes to retrieve information about the store's default pages. |
There was a problem hiding this comment.
Mention these attributes are defined in the CmsGraphQl module
keharper
approved these changes
Feb 22, 2019
|
running tests |
|
Hi @erikmarr, thank you for your contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a:
Summary
When this pull request is merged, it will fix #3342
Additional information
List all affected URLs